Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 6174f64

Browse files
Use ‘expect’ only not ‘should’ in specs
Close #10 
1 parent 2dd610c commit 6174f64

File tree

6 files changed

+81
-73
lines changed

6 files changed

+81
-73
lines changed

‎lib/ruby-stackoverflow/client/response_data.rb‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
21
module RubyStackoverflow
32
class Client
43
class ResponseData
54
attr_reader :data, :has_more, :error
65

76
def initialize(response, klass)
87
if response[:items].nil?
9-
@error = StackoverflowError.new(response)
8+
@error = StackoverflowError.new(response)
109
else
1110
@data = format_data(response[:items], klass)
1211
@has_more = response[:has_more]

‎spec/ruby-stackoverflow/badges_spec.rb‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ module RubyStackoverflow
99
it 'should find badges' do
1010
VCR.use_cassette('badges') do
1111
response = RubyStackoverflow.badges({min: 'gold', max: 'bronze', sort: 'rank'})
12-
response.data.is_a?(Array).should be_truthy
12+
13+
expect(response.data.is_a?(Array)).to be_truthy
1314
expect(response.data.count).to eq(30)
1415
expect(response.data.first.name).to eq('cryptography')
1516
end
@@ -18,7 +19,8 @@ module RubyStackoverflow
1819
it 'should find badges by ids' do
1920
VCR.use_cassette('badges_by_ids') do
2021
response = RubyStackoverflow.badges_by_ids([263, 264], {min: 'gold', max: 'bronze', sort: 'rank'})
21-
response.data.is_a?(Array).should be_truthy
22+
23+
expect(response.data.is_a?(Array)).to be_truthy
2224
expect(response.data.count).to eq(2)
2325
expect(response.data.first.name).to eq('cryptography')
2426
end
@@ -27,7 +29,8 @@ module RubyStackoverflow
2729
it 'should find badges by name' do
2830
VCR.use_cassette('badges_by_name') do
2931
response = RubyStackoverflow.badges_by_name({inname: 'teacher',min: 'gold', max: 'bronze', sort: 'rank'})
30-
response.data.is_a?(Array).should be_truthy
32+
33+
expect(response.data.is_a?(Array)).to be_truthy
3134
expect(response.data.count).to eq(1)
3235
expect(response.data.first.name).to eq('Teacher')
3336
end
@@ -36,7 +39,8 @@ module RubyStackoverflow
3639
it 'should find recently added badges' do
3740
VCR.use_cassette('badges_by_recipients') do
3841
response = RubyStackoverflow.badges_between_dates({page: 1, pagesize: 10})
39-
response.data.is_a?(Array).should be_truthy
42+
43+
expect(response.data.is_a?(Array)).to be_truthy
4044
expect(response.data.count).to eq(10)
4145
expect(response.data.first.name).to eq('Nice Answer')
4246
end
@@ -45,7 +49,8 @@ module RubyStackoverflow
4549
it 'should find recently added badges by ids' do
4650
VCR.use_cassette('badges_by_recipients_by_ids') do
4751
response = RubyStackoverflow.badges_between_dates_by_ids([146, 20],{page: 1, pagesize: 10})
48-
response.data.is_a?(Array).should be_truthy
52+
53+
expect(response.data.is_a?(Array)).to be_truthy
4954
expect(response.data.count).to eq(10)
5055
expect(response.data.first.name).to eq('Nice Question')
5156
end
@@ -54,7 +59,8 @@ module RubyStackoverflow
5459
it 'should find badges by tags' do
5560
VCR.use_cassette('badges_by_tags') do
5661
response = RubyStackoverflow.badges_by_tags({inname: 'ruby-on-rails',min: 'gold', max: 'bronze', sort: 'rank'})
57-
response.data.is_a?(Array).should be_truthy
62+
63+
expect(response.data.is_a?(Array)).to be_truthy
5864
expect(response.data.count).to eq(7)
5965
expect(response.data.first.name).to eq('ruby-on-rails')
6066
end

‎spec/ruby-stackoverflow/comments_spec.rb‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ module RubyStackoverflow
1010
it 'should fetch comments' do
1111
VCR.use_cassette('comments') do
1212
response = RubyStackoverflow.comments({min: 1, max: 10, sort: 'votes'})
13-
response.data.is_a?(Array).should be_truthy
13+
14+
expect(response.data.is_a?(Array)).to be_truthy
1415
expect(response.data.count).to eq(30)
1516
expect(response.data.first.edited).to eq(false)
1617
expect(response.data.first.score).to eq(10)
@@ -20,7 +21,8 @@ module RubyStackoverflow
2021
it 'should fetch comments by ids' do
2122
VCR.use_cassette('comments_by_ids') do
2223
response = RubyStackoverflow.comments_by_ids(['129085', '131326'])
23-
response.data.is_a?(Array).should be_truthy
24+
25+
expect(response.data.is_a?(Array)).to be_truthy
2426
expect(response.data.count).to eq(2)
2527
expect(response.data.first.edited).to eq(false)
2628
expect(response.data.first.score).to eq(10)

‎spec/ruby-stackoverflow/question_spec.rb‎

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,26 @@ module RubyStackoverflow
1010
it 'should get questions' do
1111
VCR.use_cassette('questions') do
1212
response = RubyStackoverflow.questions
13-
response.data.is_a?(Array).should be_truthy
14-
response.data.last.respond_to?(:answer_count).should be_truthy
13+
14+
expect(response.data.is_a?(Array)).to be_truthy
15+
expect(response.data.last.respond_to?(:answer_count)).to be_truthy
1516
end
1617
end
1718

1819
it 'should get questions by id' do
1920
VCR.use_cassette('questions_by_ids') do
2021
response = RubyStackoverflow.questions_by_ids(['19294359'])
21-
response.data.is_a?(Array).should be_truthy
22-
response.data.last.respond_to?(:answer_count).should be_truthy
22+
23+
expect(response.data.is_a?(Array)).to be_truthy
24+
expect(response.data.last.respond_to?(:answer_count)).to be_truthy
2325
end
2426
end
2527

2628
it 'should get answers of questions' do
2729
VCR.use_cassette('questions_answers') do
2830
response = RubyStackoverflow.answers_of_questions(['16067043','19401289'])
29-
response.data.is_a?(Array).should be_truthy
31+
32+
expect(response.data.is_a?(Array)).to be_truthy
3033
expect(response.data.last.answers.count).to eq(1)
3134
expect(response.data.first.answers.last.answer_id).to eq(19401432)
3235
end
@@ -36,54 +39,61 @@ module RubyStackoverflow
3639
VCR.use_cassette('questions_comments') do
3740
response = RubyStackoverflow.comments_of_questions(['13804832'])
3841
data = response.data.last
39-
response.data.is_a?(Array).should be_truthy
40-
data.respond_to?(:comments).should be_truthy
42+
43+
expect(response.data.is_a?(Array)).to be_truthy
44+
expect(data.respond_to?(:comments)).to be_truthy
4145
expect(data.comments.first.owner[:user_id]).to eq(87189)
4246
end
4347
end
4448

4549
it 'should get linked questions' do
4650
VCR.use_cassette('linked_questions') do
4751
response = RubyStackoverflow.linked_questions(['13804832'])
48-
response.data.is_a?(Array).should be_truthy
52+
53+
expect(response.data.is_a?(Array)).to be_truthy
4954
end
5055
end
5156

5257
it 'should get related questions' do
5358
VCR.use_cassette('related_questions') do
5459
response = RubyStackoverflow.related_questions(['13804832'])
55-
response.data.is_a?(Array).should be_truthy
60+
61+
expect(response.data.is_a?(Array)).to be_truthy
5662
end
5763
end
5864

5965
it 'should get timeline questions' do
6066
VCR.use_cassette('timeline_questions') do
6167
response = RubyStackoverflow.timeline_of_questions(['13804832','16067043'])
6268
data = response.data.first
63-
response.data.is_a?(Array).should be_truthy
64-
data.posts.first.respond_to?(:timeline_type).should be_truthy
69+
70+
expect(response.data.is_a?(Array)).to be_truthy
71+
expect(data.posts.first.respond_to?(:timeline_type)).to be_truthy
6572
expect(data.posts.first.timeline_type).to eq('comment')
6673
end
6774
end
6875

6976
it 'should get featured questions' do
7077
VCR.use_cassette('featured_questions') do
7178
response = RubyStackoverflow.featured_questions({page: 1,pagesize: 1})
72-
response.data.is_a?(Array).should be_truthy
79+
80+
expect(response.data.is_a?(Array)).to be_truthy
7381
end
7482
end
7583

7684
it 'should get unanswered questions' do
7785
VCR.use_cassette('unanswered_questions') do
7886
response = RubyStackoverflow.unanswered_questions({tagged:'rails',pagesize: 1, page: 1})
79-
response.data.is_a?(Array).should be_truthy
87+
88+
expect(response.data.is_a?(Array)).to be_truthy
8089
end
8190
end
8291

8392
it 'should get noanswered questions' do
8493
VCR.use_cassette('noanswered_questions') do
8594
response = RubyStackoverflow.noanswered_questions({tagged:'rails', pagesize: 1, page: 1})
86-
response.data.is_a?(Array).should be_truthy
95+
96+
expect(response.data.is_a?(Array)).to be_truthy
8797
end
8898
end
8999
end

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /