Commit a14da3f

committed

Merge branch 'feature/14-get-articles-by-notFound-user' into develop

2 parents 49395f4 + 588f871 commit a14da3fCopy full SHA for a14da3f

File tree

+11

-1

lines changed

src
- main/java/io/github/raeperd/realworld/domain/article
  - ArticleService.java
- test/java/io/github/raeperd/realworld
  - IntegrationTest.java

+11

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public Page<Article> getArticleFavoritedByUsername(UserName username, Pageable p`
`55`	`55`	`return userFindService.findByUsername(username)`
`56`	`56`	`.map(user -> articleRepository.findAllByUserFavoritedContains(user, pageable)`
`57`	`57`	`.map(article -> article.updateFavoriteByUser(user)))`
`58`		`- .orElseThrow(NoSuchElementException::new);`
	`58`	`+ .orElse(Page.empty());`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`@Transactional(readOnly = true)`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,16 @@ void get_articles_favorited_by_username() throws Exception {`
`239`	`239`	`.andExpect(jsonPath("articles[0].favorited", is(true)));`
`240`	`240`	`}`
`241`	`241`
	`242`	`+ @Order(13)`
	`243`	`+ @Test`
	`244`	`+ void get_articles_favorited_by_username_not_exists() throws Exception {`
	`245`	`+ mockMvc.perform(get("/articles?favorited={username}", "jane")`
	`246`	`+ .header(AUTHORIZATION, "Token " + token))`
	`247`	`+ .andExpect(status().isOk())`
	`248`	`+ .andExpect(jsonPath("articles").isEmpty())`
	`249`	`+ .andExpect(jsonPath("articlesCount", is(0)));`
	`250`	`+ }`
	`251`	`+`
`242`	`252`	`@Order(13)`
`243`	`253`	`@Test`
`244`	`254`	`void get_feed() throws Exception {`

Comments

(0)