Commit a2680e7

committed

Raise TypeError instead where appropriate.

1 parent 1134029 commit a2680e7Copy full SHA for a2680e7

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ static PyObject object_call(ObjectData self, PyObject args, PyObject kwds) {`
`144`	`144`	`return NULL;`
`145`	`145`	`}`
`146`	`146`	`} else {`
`147`		`- PyErr_Format(PyExc_ValueError,`
	`147`	`+ PyErr_Format(PyExc_TypeError,`
`148`	`148`	`"Unsupported type of argument %d when calling quickjs object: %s.",`
`149`	`149`	`i,`
`150`	`150`	`Py_TYPE(item)->tp_name);`
`@@ -235,7 +235,7 @@ static PyObject quickjs_to_python(ContextData context_obj, JSValue value) {`
`235`	`235`	`object->context = context_obj;`
`236`	`236`	`object->object = JS_DupValue(context, value);`
`237`	`237`	`} else {`
`238`		`- PyErr_Format(PyExc_ValueError, "Unknown quickjs tag: %d", tag);`
	`238`	`+ PyErr_Format(PyExc_TypeError, "Unknown quickjs tag: %d", tag);`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`JS_FreeValue(context, value);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ def test_function_call_unsupported_arg(self):`
`191`	`191`	`return 40 + x;`
`192`	`192`	`}`
`193`	`193`	`""")`
`194`		`- with self.assertRaisesRegex(ValueError, "Unsupported type"):`
	`194`	`+ with self.assertRaisesRegex(TypeError, "Unsupported type"):`
`195`	`195`	`self.assertEqual(f({}), 42)`
`196`	`196`
`197`	`197`	`def test_json(self):`

Comments

(0)