Commit 83084ac

authored

Merge pull request #152 from PrashantkumarWebDeveloper/patch-1

Make item icons optional

2 parents 5958c7d + df6b8a2 commit 83084acCopy full SHA for 83084ac

File tree

+11

-8

lines changed

+11

-8

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public virtual class LookupSearchResult implements Comparable {`
`15`	`15`	`/**`
`16`	`16`	`* @param id the lookup entry identifier (generally a record ID)`
`17`	`17`	`* @param sObjectType Optional - The sObject type of the selected record. This value is not used for lookup rendering. It's passed back to the selection handler in case you search on multiple object types.`
`18`		`- * @param icon Optional - A qualified SLDS icon name taken from https://www.lightningdesignsystem.com/icons. It defaults to standard:default.`
	`18`	`+ * @param icon Optional - A qualified SLDS icon name taken from https://www.lightningdesignsystem.com/icons. No icon is displayed by default.`
`19`	`19`	`* @param title Required - The label of the lookup entry`
`20`	`20`	`* @param subtitle Optional - A subtitle that is displayed under the lookup entry label`
`21`	`21`	`*/`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`<div class={getComboboxClass} role="none">`
`18`	`18`	`<template lwc:if={isSingleEntry}>`
`19`	`19`	`<lightning-icon`
	`20`	`+ lwc:if={getSelectIconName}`
`20`	`21`	`icon-name={getSelectIconName}`
`21`	`22`	`size="small"`
`22`	`23`	`alternative-text="Selected item icon"`
`@@ -106,7 +107,10 @@`
`106`	`107`	`onclick={handleResultClick}`
`107`	`108`	`data-recordid={item.result.id}`
`108`	`109`	`>`
`109`		`- <span class="slds-media__figure slds-listbox__option-icon">`
	`110`	`+ <span`
	`111`	`+ class="slds-media__figure slds-listbox__option-icon"`
	`112`	`+ lwc:if={item.result.icon}`
	`113`	`+ >`
`110`	`114`	`<lightning-icon`
`111`	`115`	`icon-name={item.result.icon}`
`112`	`116`	`size="small"`
`@@ -193,7 +197,7 @@`
`193`	`197`	`onremove={handleRemoveSelectedItem}`
`194`	`198`	`name={item.id}`
`195`	`199`	`>`
`196`		`- <lightning-icon icon-name={item.icon}></lightning-icon>`
	`200`	`+ <lightning-icon icon-name={item.icon}lwc:if={item.icon}></lightning-icon>`
`197`	`201`	`</lightning-pill>`
`198`	`202`	`</li>`
`199`	`203`	`</template>`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,10 +104,6 @@ export default class Lookup extends NavigationMixin(LightningElement) {`
`104`	`104`	`result.titleFormatted = result.title;`
`105`	`105`	`result.subtitleFormatted = result.subtitle;`
`106`	`106`	`}`
`107`		`- // Add icon if missing`
`108`		`- if (typeof result.icon === 'undefined') {`
`109`		`- result.icon = 'standard:default';`
`110`		`- }`
`111`	`107`	`return result;`
`112`	`108`	`});`
`113`	`109`	`// Add local state and dynamic class to search results`
`@@ -414,7 +410,10 @@ export default class Lookup extends NavigationMixin(LightningElement) {`
`414`	`410`	`if (this.isMultiEntry) {`
`415`	`411`	`css += 'slds-input-has-icon_right';`
`416`	`412`	`} else {`
`417`		`- css += this.hasSelection() ? 'slds-input-has-icon_left-right' : 'slds-input-has-icon_right';`
	`413`	`+ css +=`
	`414`	`+ this.hasSelection() && this._curSelection[0].icon`
	`415`	`+ ? 'slds-input-has-icon_left-right'`
	`416`	`+ : 'slds-input-has-icon_right';`
`418`	`417`	`}`
`419`	`418`	`return css;`
`420`	`419`	`}`

Comments

(0)