|
4 | 4 | from pathlib import Path |
5 | 5 | import tempfile |
6 | 6 | from unittest.mock import patch |
| 7 | +import xml.etree.ElementTree as ET |
7 | 8 |
|
8 | 9 | from pdfrw import PdfReader |
9 | 10 | from PIL import Image |
|
16 | 17 | fig = {"data": [], "layout": {"title": {"text": "figure title"}}} |
17 | 18 |
|
18 | 19 |
|
| 20 | +def create_figure(width=None, height=None): |
| 21 | + """Create a simple figure with optional layout dimensions.""" |
| 22 | + layout = {} |
| 23 | + if width: |
| 24 | + layout["width"] = width |
| 25 | + if height: |
| 26 | + layout["height"] = height |
| 27 | + |
| 28 | + return go.Figure(data=[go.Scatter(x=[1, 2, 3], y=[1, 2, 3])], layout=layout) |
| 29 | + |
| 30 | + |
| 31 | +def parse_svg_dimensions(svg_bytes): |
| 32 | + """Parse width and height from SVG bytes.""" |
| 33 | + svg_str = svg_bytes.decode("utf-8") |
| 34 | + root = ET.fromstring(svg_str) |
| 35 | + width = root.get("width") |
| 36 | + height = root.get("height") |
| 37 | + return int(width) if width else None, int(height) if height else None |
| 38 | + |
| 39 | + |
19 | 40 | def check_image(path_or_buffer, size=(700, 500), format="PNG"): |
20 | 41 | if format == "PDF": |
21 | 42 | img = PdfReader(path_or_buffer) |
@@ -314,3 +335,42 @@ def test_get_chrome(): |
314 | 335 |
|
315 | 336 | # Verify that kaleido.get_chrome_sync was called |
316 | 337 | mock_get_chrome.assert_called_once() |
| 338 | + |
| 339 | + |
| 340 | +def test_width_height_priority(): |
| 341 | + """Test width/height priority: arguments > layout.width/height > defaults.""" |
| 342 | + |
| 343 | + # Test case 1: Arguments override layout |
| 344 | + fig = create_figure(width=800, height=600) |
| 345 | + svg_bytes = pio.to_image(fig, format="svg", width=1000, height=900) |
| 346 | + width, height = parse_svg_dimensions(svg_bytes) |
| 347 | + assert width == 1000 and height == 900, ( |
| 348 | + "Arguments should override layout dimensions" |
| 349 | + ) |
| 350 | + |
| 351 | + # Test case 2: Layout dimensions used when no arguments |
| 352 | + fig = create_figure(width=800, height=600) |
| 353 | + svg_bytes = pio.to_image(fig, format="svg") |
| 354 | + width, height = parse_svg_dimensions(svg_bytes) |
| 355 | + assert width == 800 and height == 600, ( |
| 356 | + "Layout dimensions should be used when no arguments provided" |
| 357 | + ) |
| 358 | + |
| 359 | + # Test case 3: Partial override (only width argument) |
| 360 | + fig = create_figure(width=800, height=600) |
| 361 | + svg_bytes = pio.to_image(fig, format="svg", width=1200) |
| 362 | + width, height = parse_svg_dimensions(svg_bytes) |
| 363 | + assert width == 1200 and height == 600, ( |
| 364 | + "Width argument should override layout, height should use layout" |
| 365 | + ) |
| 366 | + |
| 367 | + # Test case 4: Defaults used when no layout or arguments |
| 368 | + fig = create_figure() |
| 369 | + svg_bytes = pio.to_image(fig, format="svg") |
| 370 | + width, height = parse_svg_dimensions(svg_bytes) |
| 371 | + assert width == pio.defaults.default_width, ( |
| 372 | + "Default width should be used when no layout or argument" |
| 373 | + ) |
| 374 | + assert height == pio.defaults.default_height, ( |
| 375 | + "Default height should be used when no layout or argument" |
| 376 | + ) |
0 commit comments