Commit 681d80e

authored

Merge pull request #5112 from plotly/double-plotlyjs

Fix issue of plotly.js being embedded twice in notebook

2 parents 94790d2 + f39dbfd commit 681d80eCopy full SHA for 681d80e

File tree

1 file changed

-7

lines changed

plotly/io
- _base_renderers.py

1 file changed

-7

lines changed

`‎plotly/io/_base_renderers.py‎`

Lines changed: 8 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -254,6 +254,7 @@ def __init__(`
`254`	`254`	`auto_play=False,`
`255`	`255`	`post_script=None,`
`256`	`256`	`animation_opts=None,`
	`257`	`+ include_plotlyjs=True,`
`257`	`258`	`):`
`258`	`259`
`259`	`260`	`self.config = dict(config) if config else {}`
`@@ -263,6 +264,7 @@ def __init__(`
`263`	`264`	`self.full_html = full_html`
`264`	`265`	`self.animation_opts = animation_opts`
`265`	`266`	`self.post_script = post_script`
	`267`	`+ self.include_plotlyjs = "cdn" if self.connected else include_plotlyjs`
`266`	`268`
`267`	`269`	`def activate(self):`
`268`	`270`	`if self.global_init:`
`@@ -307,12 +309,7 @@ def to_mimebundle(self, fig_dict):`
`307`	`309`
`308`	`310`	`from plotly.io import to_html`
`309`	`311`
`310`		`- if self.connected:`
`311`		`- include_plotlyjs = "cdn"`
`312`		`- include_mathjax = "cdn"`
`313`		`- else:`
`314`		`- include_plotlyjs = True`
`315`		`- include_mathjax = "cdn"`
	`312`	`+ include_mathjax = "cdn"`
`316`	`313`
`317`	`314`	`# build post script`
`318`	`315`	`post_script = [`
`@@ -352,7 +349,7 @@ def to_mimebundle(self, fig_dict):`
`352`	`349`	`fig_dict,`
`353`	`350`	`config=self.config,`
`354`	`351`	`auto_play=self.auto_play,`
`355`		`- include_plotlyjs=include_plotlyjs,`
	`352`	`+ include_plotlyjs=self.include_plotlyjs,`
`356`	`353`	`include_mathjax=include_mathjax,`
`357`	`354`	`post_script=post_script,`
`358`	`355`	`full_html=self.full_html,`
`@@ -385,6 +382,7 @@ def __init__(`
`385`	`382`	`auto_play=False,`
`386`	`383`	`post_script=None,`
`387`	`384`	`animation_opts=None,`
	`385`	`+ include_plotlyjs=False,`
`388`	`386`	`):`
`389`	`387`	`super(NotebookRenderer, self).__init__(`
`390`	`388`	`connected=connected,`
`@@ -394,6 +392,7 @@ def __init__(`
`394`	`392`	`auto_play=auto_play,`
`395`	`393`	`post_script=post_script,`
`396`	`394`	`animation_opts=animation_opts,`
	`395`	`+ include_plotlyjs=include_plotlyjs,`
`397`	`396`	`)`
`398`	`397`
`399`	`398`
`@@ -421,6 +420,7 @@ def __init__(`
`421`	`420`	`auto_play=auto_play,`
`422`	`421`	`post_script=post_script,`
`423`	`422`	`animation_opts=animation_opts,`
	`423`	`+ include_plotlyjs=False,`
`424`	`424`	`)`
`425`	`425`
`426`	`426`
`@@ -448,6 +448,7 @@ def __init__(`
`448`	`448`	`auto_play=auto_play,`
`449`	`449`	`post_script=post_script,`
`450`	`450`	`animation_opts=animation_opts,`
	`451`	`+ include_plotlyjs=False,`
`451`	`452`	`)`
`452`	`453`
`453`	`454`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 681d80e

File tree

1 file changed

1 file changed

`‎plotly/io/_base_renderers.py‎`

0 commit comments