Commit 390c09d

committed

Merge pull request #308 from plotly/return-figures-from-figure-factory

Return `Figure`, not `dict`.

2 parents 8f0ac6e + dced8ed commit 390c09dCopy full SHA for 390c09d

File tree

1 file changed

-7

lines changed

plotly
- tools.py

1 file changed

-7

lines changed

`‎plotly/tools.py‎`

Lines changed: 5 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1668,7 +1668,7 @@ def create_quiver(x, y, u, v, scale=.1, arrow_scale=.3,`
`1668`	`1668`	`data = [quiver]`
`1669`	`1669`	`layout = graph_objs.Layout(hovermode='closest')`
`1670`	`1670`
`1671`		`- return dict(data=data, layout=layout)`
	`1671`	`+ return graph_objs.Figure(data=data, layout=layout)`
`1672`	`1672`
`1673`	`1673`	`@staticmethod`
`1674`	`1674`	`def create_streamline(x, y, u, v,`
`@@ -1776,7 +1776,7 @@ def create_streamline(x, y, u, v,`
`1776`	`1776`	`data = [streamline]`
`1777`	`1777`	`layout = graph_objs.Layout(hovermode='closest')`
`1778`	`1778`
`1779`		`- return dict(data=data, layout=layout)`
	`1779`	`+ return graph_objs.Figure(data=data, layout=layout)`
`1780`	`1780`
`1781`	`1781`	`@staticmethod`
`1782`	`1782`	`def _make_increasing_ohlc(open, high, low, close, dates, **kwargs):`
`@@ -2013,7 +2013,7 @@ def create_ohlc(open, high, low, close,`
`2013`	`2013`	`layout = graph_objs.Layout(xaxis=dict(zeroline=False),`
`2014`	`2014`	`hovermode='closest')`
`2015`	`2015`
`2016`		`- return dict(data=data, layout=layout)`
	`2016`	`+ return graph_objs.Figure(data=data, layout=layout)`
`2017`	`2017`
`2018`	`2018`	`@staticmethod`
`2019`	`2019`	`def _make_increasing_candle(open, high, low, close, dates, **kwargs):`
`@@ -2239,7 +2239,7 @@ def create_candlestick(open, high, low, close,`
`2239`	`2239`	`data = candle_incr_data + candle_decr_data`
`2240`	`2240`
`2241`	`2241`	`layout = graph_objs.Layout()`
`2242`		`- return dict(data=data, layout=layout)`
	`2242`	`+ return graph_objs.Figure(data=data, layout=layout)`
`2243`	`2243`
`2244`	`2244`	`@staticmethod`
`2245`	`2245`	`def create_distplot(hist_data, group_labels,`
`@@ -2419,9 +2419,7 @@ def create_distplot(hist_data, group_labels,`
`2419`	`2419`	`position=0.0))`
`2420`	`2420`
`2421`	`2421`	`data = sum(data, [])`
`2422`		`- dist_fig = dict(data=data, layout=layout)`
`2423`		`-`
`2424`		`- return dist_fig`
	`2422`	`+ return graph_objs.Figure(data=data, layout=layout)`
`2425`	`2423`
`2426`	`2424`
`2427`	`2425`	`class _Quiver(FigureFactory):`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 390c09d

File tree

1 file changed

1 file changed

`‎plotly/tools.py‎`

0 commit comments