Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit bb98fef

Browse files
v4.9.4.1 release candidate (#1965)
* v4.9.4.1 release candidate * Reduce some of the warning noise * Reduce some of the warning noise
1 parent 771d584 commit bb98fef

File tree

8 files changed

+18
-16
lines changed

8 files changed

+18
-16
lines changed

‎DESCRIPTION‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: plotly
22
Title: Create Interactive Web Graphics via 'plotly.js'
3-
Version: 4.9.4.9000
3+
Version: 4.9.4.1
44
Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
55
email = "cpsievert1@gmail.com", comment = c(ORCID = "0000-0002-4958-2844")),
66
person("Chris", "Parmer", role = "aut",
@@ -36,7 +36,7 @@ Imports:
3636
base64enc,
3737
htmltools (>= 0.3.6),
3838
htmlwidgets (>= 1.5.2.9001),
39-
tidyr,
39+
tidyr (>= 1.0.0),
4040
RColorBrewer,
4141
dplyr,
4242
vctrs,

‎NEWS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 4.9.4.9000
1+
# 4.9.4.1
22

33
## BUG FIXES
44

‎R/ggplotly.R‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ gg2list <- function(p, width = NULL, height = NULL,
346346
x <- reComputeGroup(x, z)
347347
tib <- tibble::as_tibble(x[c("PANEL", "group")])
348348
tib[["key"]] <- key
349-
nested <- tidyr::nest(tib, key, .key = key)
349+
nested <- tidyr::nest(tib, key = key)
350350
# reduce the dimensions of list column elements from 2 to 1
351351
nested$key <- lapply(nested$key, function(x) x[[1]])
352352
nested

‎tests/testthat/test-ggplot-bar.R‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ test_that('guides(colour="none") does not affect fill legend', {
127127
test_that("guides(fill=FALSE) does not affect colour legend", {
128128
gg <- ggplot(data = df, aes(x = time, y = total_bill, colour = time)) +
129129
geom_bar(fill = "grey", stat = "identity") +
130-
guides(fill = FALSE)
130+
guides(fill = "none")
131131
info <- expect_traces(gg, 2, "aes-colour-guides-fill-FALSE")
132132
for(tr in info$data){
133133
expect_equivalent(tr$marker$color, toRGB("grey"))

‎tests/testthat/test-ggplot-quantile.R‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ test_that("Basic geom_quantile() works", {
1010
geom_point() +
1111
geom_quantile()
1212

13-
l <- plotly_build(p)$x
13+
# partial match of 'coef' to 'coefficients'
14+
l <- suppressWarnings(plotly_build(p)$x)
1415

1516
expect_length(l$data, 4)
1617

@@ -35,7 +36,8 @@ test_that("Can specify gpar() in geom_quantile()", {
3536
geom_point() +
3637
geom_quantile(colour = "red", alpha = 0.5)
3738

38-
l <- plotly_build(p)$x
39+
# partial match of 'coef' to 'coefficients'
40+
l <- suppressWarnings(plotly_build(p)$x)
3941

4042
expect_length(l$data, 4)
4143

‎tests/testthat/test-plotly-data.R‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ test_that("plotly_data returns data frame", {
1515
})
1616

1717
test_that("plotly_data preserves groups in data", {
18-
d <- plotly_data(group_by_(plot_ly(mtcars), c("vs", "am")))
18+
d <- plotly_data(group_by(plot_ly(mtcars), vs, am))
1919
expect_true(dplyr::groups(d)[[1]] == "vs")
2020
})
2121

‎tests/testthat/test-plotly-filename.R‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test_that("filename supports names with paths included ", {
1111
endpt <- sprintf("files/%s/trash", file$fid)
1212
res <- api(endpt, "POST")
1313
}
14-
f <- plotly_POST(p, filename = filename)
14+
f <- api_create(p, filename = filename)
1515
expect_match(f$filename, "awesome")
1616
expect_true(f$parented)
1717
})

‎tests/testthat/test-plotly-getfigure.R‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
1-
context("get_figure")
1+
context("api_download_plot")
22

33
test_that("requests made by a user who doesn't exist error a 404", {
44
skip_on_cran()
55
skip_if_not_master()
66
expect_error({
7-
get_figure("klmadslfjdfljdsf", 0)
7+
api_download_plot(0, "klmadslfjdfljdsf")
88
}, ".*404.*")
99
})
1010

1111
test_that("requests made to retrieve a figure that doesn't exist returns a 404", {
1212
skip_on_cran()
1313
skip_if_not_master()
1414
expect_error({
15-
get_figure("get_test_user", 18324823)
15+
api_download_plot(18324823, "get_test_user")
1616
}, ".*404.*")
1717
})
1818

1919
test_that("requests made to retrieve some elses private file errors", {
2020
skip_on_cran()
2121
skip_if_not_master()
22-
expect_error(get_figure("get_test_user", 1))
22+
expect_error(api_download_plot(1, "get_test_user"))
2323
})
2424

2525
test_that("retrieving a public figure ... works.", {
2626
skip_on_cran()
2727
skip_if_not_master()
28-
fig <- get_figure("get_test_user", 0)
28+
fig <- api_download_plot(0, "get_test_user")
2929
# get the data behind the hash
3030
p <- plotly_build(fig)$x
3131
expect_equivalent(p$data[[1]]$x, c("1", "2", "3"))
@@ -34,7 +34,7 @@ test_that("retrieving a public figure ... works.", {
3434
test_that("can add traces to a subplot figure", {
3535
skip_on_cran()
3636
skip_if_not_master()
37-
fig <- get_figure('chelsea_lyn', 6366)
37+
fig <- api_download_plot(6366, 'chelsea_lyn')
3838
p <- add_lines(fig, x = c(1, 2, 3), y = c(4, 2, 4))
3939
expect_equivalent(
4040
length(plotly_build(fig)$x$data) + 1,
@@ -45,7 +45,7 @@ test_that("can add traces to a subplot figure", {
4545
test_that("posting a hidden plot returns a secret key", {
4646
skip_on_cran()
4747
skip_if_not_master()
48-
res <- plotly_POST(plot_ly(), sharing = "secret")
48+
res <- api_create(plot_ly(), sharing = "secret")
4949
expect_true(res$share_key_enabled)
5050
expect_true(nchar(res$share_key) > 1)
5151
})

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /