Commit d89a521

VincentLangletondrejmirtes

authored and

committed

Revert wrong typehint for getSession

1 parent fca0834 commit d89a521Copy full SHA for d89a521

File tree

-11

lines changed

stubs/Symfony/Component/HttpFoundation
- Request.stub
tests/Type/Symfony/data
- request_get_session.php
- request_get_session_null.php

-11

lines changed

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,11 +26,6 @@ class Request`
`26`	`26`	`*/`
`27`	`27`	`public $cookies;`
`28`	`28`
`29`		`- /**`
`30`		`- * @return \Symfony\Component\HttpFoundation\Session\Session`
`31`		`- */`
`32`		`- public function getSession();`
`33`		`-`
`34`	`29`	`/**`
`35`	`30`	`* @return string[]`
`36`	`31`	`*/`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,14 @@`
`1`	`1`	`<?php declare(strict_types = 1);`
`2`	`2`
`3`		`-use Symfony\Component\HttpFoundation\Session\Session;`
	`3`	`+use Symfony\Component\HttpFoundation\Session\SessionInterface;`
`4`	`4`	`use function PHPStan\Testing\assertType;`
`5`	`5`
`6`	`6`	`/** @var \Symfony\Component\HttpFoundation\Request $request */`
`7`	`7`	`$request = doRequest();`
`8`	`8`
`9`	`9`	`$session1 = $request->getSession();`
`10`		`-assertType(Session::class, $request->getSession());`
	`10`	`+assertType(SessionInterface::class, $request->getSession());`
`11`	`11`
`12`	`12`	`if ($request->hasSession()) {`
`13`		`- assertType(Session::class, $request->getSession());`
	`13`	`+ assertType(SessionInterface::class, $request->getSession());`
`14`	`14`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,14 @@`
`1`	`1`	`<?php declare(strict_types = 1);`
`2`	`2`
`3`		`-use Symfony\Component\HttpFoundation\Session\Session;`
	`3`	`+use Symfony\Component\HttpFoundation\Session\SessionInterface;`
`4`	`4`	`use function PHPStan\Testing\assertType;`
`5`	`5`
`6`	`6`	`/** @var \Symfony\Component\HttpFoundation\Request $request */`
`7`	`7`	`$request = doRequest();`
`8`	`8`
`9`	`9`	`$session1 = $request->getSession();`
`10`		`-assertType(Session::class . '\|null', $request->getSession());`
	`10`	`+assertType(SessionInterface::class . '\|null', $request->getSession());`
`11`	`11`
`12`	`12`	`if ($request->hasSession()) {`
`13`		`- assertType(Session::class, $request->getSession());`
	`13`	`+ assertType(SessionInterface::class, $request->getSession());`
`14`	`14`	`}`

Comments

(0)