Commit af6ae0f

authored

Update getArgument return type in interact method

1 parent 2c3d666 commit af6ae0fCopy full SHA for af6ae0f

File tree

+22

-0

lines changed

+22

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,13 @@`
`10`	`10`	`use PHPStan\Type\ArrayType;`
`11`	`11`	`use PHPStan\Type\DynamicMethodReturnTypeExtension;`
`12`	`12`	`use PHPStan\Type\IntegerType;`
	`13`	`+use PHPStan\Type\NullType;`
`13`	`14`	`use PHPStan\Type\StringType;`
`14`	`15`	`use PHPStan\Type\Type;`
`15`	`16`	`use PHPStan\Type\TypeCombinator;`
`16`	`17`	`use PHPStan\Type\TypeUtils;`
`17`	`18`	`use function count;`
	`19`	`+use function in_array;`
`18`	`20`
`19`	`21`	`final class InputInterfaceGetArgumentDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension`
`20`	`22`	`{`
`@@ -76,6 +78,15 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method`
`76`	`78`	`}`
`77`	`79`	`}`
`78`	`80`
	`81`	`+ $method = $scope->getFunction();`
	`82`	`+ if (`
	`83`	`+ $method instanceof MethodReflection`
	`84`	`+ && $method->getName() === 'interact'`
	`85`	`+ && in_array('Symfony\Component\Console\Command\Command', $method->getDeclaringClass()->getParentClassesNames(), true)`
	`86`	`+ ) {`
	`87`	`+ $argTypes[] = new NullType();`
	`88`	`+ }`
	`89`	`+`
`79`	`90`	`return count($argTypes) > 0 ? TypeCombinator::union(...$argTypes) : null;`
`80`	`91`	`}`
`81`	`92`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,17 @@ protected function configure(): void`
`17`	`17`	`$this->addArgument('base');`
`18`	`18`	`}`
`19`	`19`
	`20`	`+ protected function interact(InputInterface $input, OutputInterface $output): int`
	`21`	`+ {`
	`22`	`+ assertType('string\|null', $input->getArgument('base'));`
	`23`	`+ assertType('string\|null', $input->getArgument('aaa'));`
	`24`	`+ assertType('string\|null', $input->getArgument('bbb'));`
	`25`	`+ assertType('array<int, string>\|string\|null', $input->getArgument('diff'));`
	`26`	`+ assertType('array<int, string>\|null', $input->getArgument('arr'));`
	`27`	`+ assertType('string\|null', $input->getArgument('both'));`
	`28`	`+ assertType('Symfony\Component\Console\Helper\QuestionHelper', $this->getHelper('question'));`
	`29`	`+ }`
	`30`	`+`
`20`	`31`	`protected function execute(InputInterface $input, OutputInterface $output): int`
`21`	`32`	`{`
`22`	`33`	`assertType('string\|null', $input->getArgument('base'));`

Comments

(0)