Commit 8b88b5f

GromNaNondrejmirtes

authored and

committed

Deprecated parent constructor must not be called

1 parent 02277ce commit 8b88b5fCopy full SHA for 8b88b5f

File tree

+20

-0

lines changed

+20

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ private function getParentConstructorClass($classReflection)`
`113`	`113`	`&& $constructor->getDeclaringClass()->getName() === $classReflection->getParentClass()->getName()`
`114`	`114`	`&& !$constructor->isAbstract()`
`115`	`115`	`&& !$constructor->isPrivate()`
	`116`	`+ && !$constructor->isDeprecated()`
`116`	`117`	`) \|\| (`
`117`	`118`	`$constructorWithClassName !== null`
`118`	`119`	`&& $constructorWithClassName->getDeclaringClass()->getName() === $classReflection->getParentClass()->getName()`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -181,3 +181,22 @@ public function __construct()`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`}`
	`184`	`+`
	`185`	`+class DeprecatedConstructor`
	`186`	`+{`
	`187`	`+ /** @deprecated */`
	`188`	`+ public function __construct()`
	`189`	`+ {`
	`190`	`+`
	`191`	`+ }`
	`192`	`+`
	`193`	`+}`
	`194`	`+`
	`195`	`+class ExtendsDeprecatedConstructor extends DeprecatedConstructor`
	`196`	`+{`
	`197`	`+ public function __construct()`
	`198`	`+ {`
	`199`	`+ // should not call deprecated parent`
	`200`	`+ }`
	`201`	`+`
	`202`	`+}`

Comments

(0)