Commit 18c0b6e

committed

OperatorRuleHelper - allow benevolent union types that contain numeric types

1 parent 1ec1d04 commit 18c0b6eCopy full SHA for 18c0b6e

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,12 @@ function (Type $type) use ($acceptedType): bool {`
`65`	`65`	`return true;`
`66`	`66`	`}`
`67`	`67`
`68`		`- return $acceptedType->isSuperTypeOf($type)->yes();`
	`68`	`+ $isSuperType = $acceptedType->isSuperTypeOf($type);`
	`69`	`+ if ($type instanceof \PHPStan\Type\BenevolentUnionType) {`
	`70`	`+ return !$isSuperType->no();`
	`71`	`+ }`
	`72`	`+`
	`73`	`+ return $isSuperType->yes();`
`69`	`74`	`}`
`70`	`75`
`71`	`76`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,10 @@ public function testRule(): void`
`36`	`36`	`'Only numeric types are allowed in +, string given on the right side.',`
`37`	`37`	`29,`
`38`	`38`	`],`
	`39`	`+ [`
	`40`	`+ 'Only numeric types are allowed in +, (array<int, string>\|false) given on the left side.',`
	`41`	`+ 110,`
	`42`	`+ ],`
`39`	`43`	`]);`
`40`	`44`	`}`
`41`	`45`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,3 +101,11 @@ function ($mixed, int $a, string $b) {`
`101`	`101`	`$mixed + $b;`
`102`	`102`	`$b + $mixed;`
`103`	`103`	`};`
	`104`	`+`
	`105`	`+function (array $array, int $int, $mixed) {`
	`106`	`+ foreach ($array as $i => $val) {`
	`107`	`+ $i + $int;`
	`108`	`+ }`
	`109`	`+`
	`110`	`+ explode($mixed, $mixed) + $int;`
	`111`	`+};`

Comments

(0)