Commit fc75deb

Seldaekondrejmirtes

authored and

committed

Fix bug parsing negative classes containing only digits ([^0-9])

1 parent dbb9665 commit fc75debCopy full SHA for fc75deb

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -625,6 +625,13 @@ private function walkGroupAst(TreeNode $ast, TrinaryLogic &$isNonEmpty, TrinaryL`
`625`	`625`	`}`
`626`	`626`	`}`
`627`	`627`
	`628`	`+ // [^0-9] should not parse as numeric-string, and [^list-everything-but-numbers] is technically`
	`629`	`+ // doable but really silly compared to just \d so we can safely assume the string is not numeric`
	`630`	`+ // for negative classes`
	`631`	`+ if ($ast->getId() === '#negativeclass') {`
	`632`	`+ $isNumeric = TrinaryLogic::createNo();`
	`633`	`+ }`
	`634`	`+`
`628`	`635`	`foreach ($children as $child) {`
`629`	`636`	`$this->walkGroupAst(`
`630`	`637`	`$child,`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -515,4 +515,7 @@ function bug11323(string $s): void {`
`515`	`515`	`if (preg_match('{(x?([1-4])\d)}', $s, $matches)) {`
`516`	`516`	`assertType('array{string, non-empty-string, numeric-string}', $matches);`
`517`	`517`	`}`
	`518`	`+ if (preg_match('{([^1-4])}', $s, $matches)) {`
	`519`	`+ assertType('array{string, non-empty-string}', $matches);`
	`520`	`+ }`
`518`	`521`	`}`

Comments

(0)