Commit f615b1a

staabmondrejmirtes

authored and

committed

non-falsy-string cannot be converted to 0

1 parent 3854cbc commit f615b1aCopy full SHA for f615b1a

File tree

-8

lines changed

-8

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@`
`31`	`31`	`use PHPStan\Type\Traits\TruthyBooleanTypeTrait;`
`32`	`32`	`use PHPStan\Type\Traits\UndecidedComparisonCompoundTypeTrait;`
`33`	`33`	`use PHPStan\Type\Type;`
	`34`	`+use PHPStan\Type\TypeCombinator;`
`34`	`35`	`use PHPStan\Type\UnionType;`
`35`	`36`	`use PHPStan\Type\VerbosityLevel;`
`36`	`37`
`@@ -183,7 +184,7 @@ public function toAbsoluteNumber(): Type`
`183`	`184`
`184`	`185`	`public function toInteger(): Type`
`185`	`186`	`{`
`186`		`- return new IntegerType();`
	`187`	`+ return TypeCombinator::remove(new IntegerType(), newConstantIntegerType(0));`
`187`	`188`	`}`
`188`	`189`
`189`	`190`	`public function toFloat(): Type`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,16 +10,16 @@`
`10`	`10`	`function hasMicroseconds(\DateTimeInterface $value, string $str): bool`
`11`	`11`	`{`
`12`	`12`	`assertType('non-falsy-string&numeric-string', $str);`
`13`		`- assertType('int', (int)$str);`
`14`		`- assertType('bool', (int)$str !== 0);`
	`13`	`+ assertType('int<min, -1>\|int<1, max>', (int)$str);`
	`14`	`+ assertType('true', (int)$str !== 0);`
`15`	`15`
`16`	`16`	`assertType('non-falsy-string&numeric-string', $value->format('u'));`
`17`		`- assertType('int', (int)$value->format('u'));`
`18`		`- assertType('bool', (int)$value->format('u') !== 0);`
	`17`	`+ assertType('int<min, -1>\|int<1, max>', (int)$value->format('u'));`
	`18`	`+ assertType('true', (int)$value->format('u') !== 0);`
`19`	`19`
`20`	`20`	`assertType('non-falsy-string&numeric-string', $value->format('v'));`
`21`		`- assertType('int', (int)$value->format('v'));`
`22`		`- assertType('bool', (int)$value->format('v') !== 0);`
	`21`	`+ assertType('int<min, -1>\|int<1, max>', (int)$value->format('v'));`
	`22`	`+ assertType('true', (int)$value->format('v') !== 0);`
`23`	`23`
`24`	`24`	`assertType('float', $value->format('u') * 1e-6);`
`25`	`25`	`assertType('float', $value->format('v') * 1e-3);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class Foo {`
`11`	`11`	`* @param truthy-string $truthyString`
`12`	`12`	`*/`
`13`	`13`	`public function bar($nonFalseyString, $truthyString) {`
`14`		`- assertType('int', (int) $nonFalseyString);`
	`14`	`+ assertType('int<min, -1>\|int<1, max>', (int) $nonFalseyString);`
`15`	`15`	`// truthy-string is an alias for non-falsy-string`
`16`	`16`	`assertType('non-falsy-string', $truthyString);`
`17`	`17`	`}`

Comments

(0)