Commit dc9e2e9

staabmondrejmirtes

authored and

committed

fix different constant arrays counts

1 parent 51275eb commit dc9e2e9Copy full SHA for dc9e2e9

File tree

+22

-8

lines changed

+22

-8

lines changed

Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,14 +51,11 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,`
`51`	`51`
`52`	`52`	`$constantKeysArrays = $keysParamType->getConstantArrays();`
`53`	`53`	`$constantValuesArrays = $valuesParamType->getConstantArrays();`
`54`		`- if ($constantKeysArrays !== [] && $constantValuesArrays !== []) {`
`55`		`- if (count($constantKeysArrays) !== count($constantValuesArrays)) {`
`56`		`- if ($this->phpVersion->throwsTypeErrorForInternalFunctions()) {`
`57`		`- return new NeverType();`
`58`		`- }`
`59`		`- return new ConstantBooleanType(false);`
`60`		`- }`
`61`		`-`
	`54`	`+ if (`
	`55`	`+ $constantKeysArrays !== []`
	`56`	`+ && $constantValuesArrays !== []`
	`57`	`+ && count($constantKeysArrays) === count($constantValuesArrays)`
	`58`	`+ ) {`
`62`	`59`	`$results = [];`
`63`	`60`	`foreach ($constantKeysArrays as $k => $constantKeysArray) {`
`64`	`61`	`$constantValueArrays = $constantValuesArrays[$k];`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,23 @@ function withUnionConstArraysDifferentKeyValueCount(): void`
`96`	`96`	`assertType("NEVER", array_combine($a, $b));`
`97`	`97`	`}`
`98`	`98`
	`99`	`+function withUnionConstArraysDifferentArraysCount(): void`
	`100`	`+{`
	`101`	`+ if (rand(0, 1)) {`
	`102`	`+ $a = [1];`
	`103`	`+ $b = ['avocado'];`
	`104`	`+ } else {`
	`105`	`+ $a = ["2", "3"];`
	`106`	`+ if (rand(0, 1)) {`
	`107`	`+ $b = ['apple', 'banana'];`
	`108`	`+ } else {`
	`109`	`+ $b = ['banana', 'pear'];`
	`110`	`+ }`
	`111`	`+ }`
	`112`	`+`
	`113`	`+ assertType("non-empty-array<1\|'2'\|'3', 'apple'\|'avocado'\|'banana'\|'pear'>", array_combine($a, $b));`
	`114`	`+}`
	`115`	`+`
`99`	`116`	`/**`
`100`	`117`	`* @param non-empty-array<int, 'foo'\|'bar'\|'baz'> $a`
`101`	`118`	`* @param non-empty-array<int, 'apple'\|'avocado'\|'banana'> $b`

Comments

(0)