Commit b5f866b

VincentLangletondrejmirtes

authored and

committed

Improve is_resource inference

1 parent a3d50de commit b5f866bCopy full SHA for b5f866b

File tree

+25

-1

lines changed

+25

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ function is_long(mixed $value): bool`
`106`	`106`
`107`	`107`	`/**`
`108`	`108`	`* @phpstan-assert-if-true =resource $value`
`109`		`- * @return bool`
	`109`	`+ * @return ($value is resource ? bool : false)`
`110`	`110`	`*/`
`111`	`111`	`function is_resource(mixed $value): bool`
`112`	`112`	`{`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1094,6 +1094,12 @@ public function testBug12087c(): void`
`1094`	`1094`	`]);`
`1095`	`1095`	`}`
`1096`	`1096`
	`1097`	`+ public function testBug10394(): void`
	`1098`	`+ {`
	`1099`	`+ $this->treatPhpDocTypesAsCertain = true;`
	`1100`	`+ $this->analyse([__DIR__ . '/data/bug-10394.php'], []);`
	`1101`	`+ }`
	`1102`	`+`
`1097`	`1103`	`public function testBug9666(): void`
`1098`	`1104`	`{`
`1099`	`1105`	`$tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting <fg=cyan>treatPhpDocTypesAsCertain: false</> in your <fg=cyan>%configurationFile%</>.';`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,18 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+namespace Bug10394;`
	`4`	`+`
	`5`	`+class SomeClass`
	`6`	`+{`
	`7`	`+ private int $integer = 0;`
	`8`	`+`
	`9`	`+ public function __construct()`
	`10`	`+ {`
	`11`	`+ // try commenting this out!`
	`12`	`+ $this->integer = 45;`
	`13`	`+`
	`14`	`+ if (is_resource($this->integer)) {`
	`15`	`+ throw new \Exception('A resource??');`
	`16`	`+ }`
	`17`	`+ }`
	`18`	`+}`

Comments

(0)