Commit 89c7bf9

committed

BacktickRule made auto-fixable

1 parent 9405233 commit 89c7bf9Copy full SHA for 89c7bf9

File tree

+49

-1

lines changed

+49

-1

lines changed

Lines changed: 24 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`use PHPStan\Php\PhpVersion;`
`10`	`10`	`use PHPStan\Rules\Rule;`
`11`	`11`	`use PHPStan\Rules\RuleErrorBuilder;`
	`12`	`+use PHPStan\ShouldNotHappenException;`
`12`	`13`
`13`	`14`	`/**`
`14`	`15`	`* @implements Rule<ShellExec>`
`@@ -34,9 +35,32 @@ public function processNode(Node $node, Scope $scope): array`
`34`	`35`	`return [];`
`35`	`36`	`}`
`36`	`37`
	`38`	`+ $argExpr = null;`
	`39`	`+ foreach ($node->parts as $part) {`
	`40`	`+ if ($part instanceof Node\InterpolatedStringPart) {`
	`41`	`+ $expr = new Node\Scalar\String_($part->value);`
	`42`	`+ } else {`
	`43`	`+ $expr = $part;`
	`44`	`+ }`
	`45`	`+`
	`46`	`+ if ($argExpr === null) {`
	`47`	`+ $argExpr = $expr;`
	`48`	`+ continue;`
	`49`	`+ }`
	`50`	`+`
	`51`	`+ $argExpr = new Node\Expr\BinaryOp\Concat($argExpr, $expr);`
	`52`	`+ }`
	`53`	`+`
	`54`	`+ if ($argExpr === null) {`
	`55`	`+ throw new ShouldNotHappenException();`
	`56`	`+ }`
	`57`	`+`
`37`	`58`	`return [`
`38`	`59`	`RuleErrorBuilder::message('Backtick operator is deprecated in PHP 8.5. Use shell_exec() function call instead.')`
`39`	`60`	`->identifier('backtick.deprecated')`
	`61`	`+ ->fixNode($node, static fn () => new Node\Expr\FuncCall(new Node\Name('shell_exec'), [`
	`62`	`+ new Node\Arg($argExpr),`
	`63`	`+ ]))`
`40`	`64`	`->build(),`
`41`	`65`	`];`
`42`	`66`	`}`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`use PHPStan\Php\PhpVersion;`
`6`	`6`	`use PHPStan\Rules\Rule;`
`7`	`7`	`use PHPStan\Testing\RuleTestCase;`
	`8`	`+use PHPUnit\Framework\Attributes\RequiresPhp;`
`8`	`9`	`use const PHP_VERSION_ID;`
`9`	`10`
`10`	`11`	`/**`
`@@ -27,9 +28,23 @@ public function testRule(): void`
`27`	`28`	`'Backtick operator is deprecated in PHP 8.5. Use shell_exec() function call instead.',`
`28`	`29`	`4,`
`29`	`30`	`],`
	`31`	`+ [`
	`32`	`+ 'Backtick operator is deprecated in PHP 8.5. Use shell_exec() function call instead.',`
	`33`	`+ 5,`
	`34`	`+ ],`
	`35`	`+ [`
	`36`	`+ 'Backtick operator is deprecated in PHP 8.5. Use shell_exec() function call instead.',`
	`37`	`+ 6,`
	`38`	`+ ],`
`30`	`39`	`];`
`31`	`40`	`}`
`32`	`41`	`$this->analyse([__DIR__ . '/data/backtick.php'], $errors);`
`33`	`42`	`}`
`34`	`43`
	`44`	`+ #[RequiresPhp('>= 8.5')]`
	`45`	`+ public function testFix(): void`
	`46`	`+ {`
	`47`	`+ $this->fix(__DIR__ . '/data/backtick.php', __DIR__ . '/data/backtick.php.fixed');`
	`48`	`+ }`
	`49`	`+`
`35`	`50`	`}`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`<?php`
`2`	`2`
`3`		`-function (): void {`
	`3`	`+function (string$s, string$t): void {`
`4`	`4`	`echo "foo";`;
	`5`	+ `$s$a`;
	`6`	+ `$s$a foo $t`;
`5`	`7`	`};`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,7 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+function (string $s, string $t): void {`
	`4`	`+ shell_exec('echo "foo";');`
	`5`	`+ shell_exec($s . ' ' . $a);`
	`6`	`+ shell_exec($s . ' ' . $a . ' foo ' . $t);`
	`7`	`+};`

Comments

(0)