Commit 6db6c4b

committed

Notes on questions for next steps

1 parent c5a6e8b commit 6db6c4bCopy full SHA for 6db6c4b

File tree

+23

-5

lines changed

+23

-5

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -316,6 +316,12 @@ public function equals(Type $type): bool`
`316`	`316`
`317`	`317`	`public function isCallable(): TrinaryLogic`
`318`	`318`	`{`
	`319`	`+ // @todo is there a way to fetch the full scope here.`
	`320`	`+ // An OutOfClassScope causes frivolous errors when checking if a`
	`321`	`+ // non-static method was invoked statically in its own class, which`
	`322`	`+ // is allowed per: https://3v4l.org/mTa9S.`
	`323`	`+ // Should add an optional scope parameter to isCallable and if null,`
	`324`	`+ // create a new OutOfClassScope instance.`
`319`	`325`	`$typeAndMethod = $this->findTypeAndMethodName(new OutOfClassScope());`
`320`	`326`	`if ($typeAndMethod === null) {`
`321`	`327`	`return TrinaryLogic::createNo();`

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -450,11 +450,18 @@ public function testBug5782(): void`
`450`	`450`	`$this->analyse([__DIR__ . '/data/bug-5782.php'], [`
`451`	`451`	`[`
`452`	`452`	`'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',`
`453`		`- 22,`
	`453`	`+ 23,`
`454`	`454`	`],`
`455`	`455`	`[`
`456`	`456`	`'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',`
`457`		`- 26,`
	`457`	`+ 30,`
	`458`	`+ ],`
	`459`	`+ // @todo this should also error on mixed type, but doesn't?`
	`460`	`+ // ConstantStringType::getCallableParametersAcceptors returns a`
	`461`	`+ // MixedType but that doesn't cause an error like ConstantArrayType.`
	`462`	`+ [`
	`463`	`+ 'Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, array{\'Bug5782\\\HelloWorld\', \'sayGoodbye\'} given.',`
	`464`	`+ 31,`
`458`	`465`	`],`
`459`	`466`	`]);`
`460`	`467`	`}`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,17 @@ public function sayGoodbye(): void`
`16`	`16`
`17`	`17`	`}`
`18`	`18`
	`19`	`+class FooWorld`
	`20`	`+{`
	`21`	`+ public function bazBar(): void`
	`22`	`+ {`
	`23`	`+ $closure1 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayGoodbye']);`
	`24`	`+ }`
	`25`	`+}`
	`26`	`+`
`19`	`27`	`function baz() {`
`20`	`28`	`$closure1 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayHello']);`
`21`	`29`	`$closure2 = \Closure::fromCallable('\Bug5782\HelloWorld::sayHello');`
`22`	`30`	`$closure3 = \Closure::fromCallable([\Bug5782\HelloWorld::class, 'sayGoodbye']);`
`23`		`- // @todo this should also error on mixed type, but doesn't?`
`24`		`- // ConstantStringType::getCallableParametersAcceptors returns a MixedType`
`25`		`- // but that doesn't cause an error like ConstantArrayType.`
`26`	`31`	`$closure4 = \Closure::fromCallable('Bug5782\HelloWorld::sayGoodbye');`
`27`	`32`	`}`

Comments

(0)