Commit 13841eb

committed

infinite loop in never returning function is allowed

1 parent d1f76fc commit 13841ebCopy full SHA for 13841eb

File tree

+14

-0

lines changed

+14

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`use PHPStan\Rules\Rule;`
`14`	`14`	`use PHPStan\Rules\RuleErrorBuilder;`
`15`	`15`	`use PHPStan\Type\Constant\ConstantBooleanType;`
	`16`	`+use PHPStan\Type\NeverType;`
`16`	`17`
`17`	`18`	`/**`
`18`	`19`	`* @implements Rule<BreaklessWhileLoopNode>`
`@@ -67,6 +68,12 @@ public function processNode(`
`67`	`68`	`$originalNode = $node->getOriginalNode();`
`68`	`69`	`$exprType = $this->helper->getBooleanType($scope, $originalNode->cond);`
`69`	`70`	`if ($exprType->isTrue()->yes()) {`
	`71`	`+ $ref = $scope->getFunction() ?? $scope->getAnonymousFunctionReflection();`
	`72`	`+`
	`73`	`+ if ($ref !== null && $ref->getReturnType() instanceof NeverType) {`
	`74`	`+ return [];`
	`75`	`+ }`
	`76`	`+`
`70`	`77`	`$addTip = function (RuleErrorBuilder $ruleErrorBuilder) use ($scope, $originalNode): RuleErrorBuilder {`
`71`	`78`	`if (!$this->treatPhpDocTypesAsCertain) {`
`72`	`79`	`return $ruleErrorBuilder;`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`use PHPStan\Rules\Rule;`
`6`	`6`	`use PHPStan\Testing\RuleTestCase;`
	`7`	`+use PHPUnit\Framework\Attributes\RequiresPhp;`
`7`	`8`
`8`	`9`	`/**`
`9`	`10`	`* @extends RuleTestCase<WhileLoopAlwaysTrueConditionRule>`
`@@ -47,4 +48,10 @@ public function testRule(): void`
`47`	`48`	`]);`
`48`	`49`	`}`
`49`	`50`
	`51`	`+ #[RequiresPhp('>= 8.1')]`
	`52`	`+ public function testRulePHP81(): void`
	`53`	`+ {`
	`54`	`+ $this->analyse([__DIR__ . '/data/while-loop-true-php81.php'], []);`
	`55`	`+ }`
	`56`	`+`
`50`	`57`	`}`

Comments

(0)