Commit 1029bba

VincentLangletondrejmirtes

authored and

committed

Compute allowedArrayType only once

1 parent c47c304 commit 1029bbaCopy full SHA for 1029bba

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,18 +58,18 @@ public function processNode(Node $node, Scope $scope): array`
`58`	`58`	`return [];`
`59`	`59`	`}`
`60`	`60`
`61`		`- $phpVersion = $this->phpVersion;`
	`61`	`+ $allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion);`
`62`	`62`	`$dimensionType = $this->ruleLevelHelper->findTypeToCheck(`
`63`	`63`	`$scope,`
`64`	`64`	`$node->dim,`
`65`	`65`	`'',`
`66`		`- static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimType)->yes(),`
	`66`	`+ static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),`
`67`	`67`	`)->getType();`
`68`	`68`	`if ($dimensionType instanceof ErrorType) {`
`69`	`69`	`return [];`
`70`	`70`	`}`
`71`	`71`
`72`		`- $isSuperType = AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimensionType);`
	`72`	`+ $isSuperType = $allowedArrayKeys->isSuperTypeOf($dimensionType);`
`73`	`73`	`if ($isSuperType->yes() \|\| ($isSuperType->maybe() && !$this->reportMaybes)) {`
`74`	`74`	`return [];`
`75`	`75`	`}`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,18 +39,18 @@ public function processNode(Node $node, Scope $scope): array`
`39`	`39`	`return [];`
`40`	`40`	`}`
`41`	`41`
`42`		`- $phpVersion = $this->phpVersion;`
	`42`	`+ $allowedArrayKeys = AllowedArrayKeysTypes::getType($this->phpVersion);`
`43`	`43`	`$dimensionType = $this->ruleLevelHelper->findTypeToCheck(`
`44`	`44`	`$scope,`
`45`	`45`	`$node->key,`
`46`	`46`	`'',`
`47`		`- static fn (Type $dimType): bool => AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimType)->yes(),`
	`47`	`+ static fn (Type $dimType): bool => $allowedArrayKeys->isSuperTypeOf($dimType)->yes(),`
`48`	`48`	`)->getType();`
`49`	`49`	`if ($dimensionType instanceof ErrorType) {`
`50`	`50`	`return [];`
`51`	`51`	`}`
`52`	`52`
`53`		`- $isSuperType = AllowedArrayKeysTypes::getType($phpVersion)->isSuperTypeOf($dimensionType);`
	`53`	`+ $isSuperType = $allowedArrayKeys->isSuperTypeOf($dimensionType);`
`54`	`54`	`if ($isSuperType->yes()) {`
`55`	`55`	`return [];`
`56`	`56`	`}`

Comments

(0)