Commit c3fcbe2

committed

move is-test-case check into TestMethodsHelper

1 parent 4bf9ac2 commit c3fcbe2Copy full SHA for c3fcbe2

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`	`use PHPStan\Rules\Rule;`
`9`	`9`	`use PHPStan\Type\ObjectType;`
`10`	`10`	`use PHPStan\Type\Type;`
`11`		`-use PHPUnit\Framework\TestCase;`
`12`	`11`	`use function array_slice;`
`13`	`12`	`use function count;`
`14`	`13`	`use function max;`
`@@ -62,10 +61,7 @@ public function processNode(Node $node, Scope $scope): array`
`62`	`61`
`63`	`62`	`$method = $scope->getFunction();`
`64`	`63`	`$classReflection = $scope->getClassReflection();`
`65`		`- if (`
`66`		`- $classReflection === null`
`67`		`- \|\| !$classReflection->is(TestCase::class)`
`68`		`- ) {`
	`64`	`+ if ($classReflection === null) {`
`69`	`65`	`return [];`
`70`	`66`	`}`
`71`	`67`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`use PHPStan\PhpDoc\ResolvedPhpDocBlock;`
`7`	`7`	`use PHPStan\Reflection\ClassReflection;`
`8`	`8`	`use PHPStan\Type\FileTypeMapper;`
	`9`	`+use PHPUnit\Framework\TestCase;`
`9`	`10`	`use ReflectionMethod;`
`10`	`11`	`use function str_starts_with;`
`11`	`12`	`use function strtolower;`
`@@ -31,6 +32,10 @@ public function __construct(`
`31`	`32`	`*/`
`32`	`33`	`public function getTestMethods(ClassReflection $classReflection, Scope $scope): array`
`33`	`34`	`{`
	`35`	`+ if (!$classReflection->is(TestCase::class)) {`
	`36`	`+ return [];`
	`37`	`+ }`
	`38`	`+`
`34`	`39`	`$testMethods = [];`
`35`	`40`	`foreach ($classReflection->getNativeReflection()->getMethods() as $reflectionMethod) {`
`36`	`41`	`if (!$reflectionMethod->isPublic()) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ protected function getRule(): Rule`
`14`	`14`	`{`
`15`	`15`	`/** @phpstan-ignore phpstanApi.classConstant */`
`16`	`16`	`$rule = self::getContainer()->getByType(MissingMethodReturnTypehintRule::class);`
`17`		`-`
	`17`	`+`
`18`	`18`	`return $rule;`
`19`	`19`	`}`
`20`	`20`

Comments

(0)