-
Notifications
You must be signed in to change notification settings - Fork 111
Added @covers-class information to *RuleTests
#703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@staabm
staabm
force-pushed
the
covers
branch
from
October 26, 2025 08:32
49d5f7a to
4699cf4
Compare
@staabm
staabm
changed the title
(削除) Added
(追記) Added Oct 26, 2025
@covers-class informtation to *RuleTests (削除ここまで)@covers-class information to *RuleTests (追記ここまで)
we could add this annotations (or attributes equivalent on new phpversions) with a auto-fixable phpstan rule.
doing manually for now to see whether its worth it
What exactly @covers achieves in Infection? What if we fix a bug in NodeScopeResolver but write a test for a specific rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
goal: speedup infection process
see phpstan/build-infection#11 (comment)