Commit ea25caa

committed

Fix UsageOfDeprecatedCastRule - it reported all casts, not just (string)

1 parent 9d8e7d4 commit ea25caaCopy full SHA for ea25caa

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`use function sprintf;`
`11`	`11`
`12`	`12`	`/**`
`13`		`- * @implements Rule<Cast>`
	`13`	`+ * @implements Rule<Cast\String_>`
`14`	`14`	`*/`
`15`	`15`	`class UsageOfDeprecatedCastRule implements Rule`
`16`	`16`	`{`
`@@ -24,7 +24,7 @@ public function __construct(DeprecatedScopeHelper $deprecatedScopeHelper)`
`24`	`24`
`25`	`25`	`public function getNodeType(): string`
`26`	`26`	`{`
`27`		`- return Cast::class;`
	`27`	`+ return Cast\String_::class;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public function processNode(Node $node, Scope $scope): array`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,3 +24,7 @@ function deprecatedScope(Foo $foo): string`
`24`	`24`	`{`
`25`	`25`	`return (string) $foo;`
`26`	`26`	`}`
	`27`	`+`
	`28`	`+function foo2(Foo $foo): string {`
	`29`	`+ return (int) $foo;`
	`30`	`+}`

Comments

(0)