Commit 0dfd45c

authored

Merge pull request #6 from michalbundyra/hotfix/double-mock

Allow to mock the same function with defferent arguments in the namespace

2 parents 291569e + 748c3d7 commit 0dfd45cCopy full SHA for 0dfd45c

File tree

+45

-7

lines changed

+45

-7

lines changed

Lines changed: 17 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,10 +56,23 @@ public function __construct($namespace, Prophet $prophet)`
`56`	`56`	`*/`
`57`	`57`	`public function __call($functionName, array $arguments)`
`58`	`58`	`{`
`59`		`- $delegateBuilder = new MockDelegateFunctionBuilder();`
`60`		`- $delegateBuilder->build($functionName);`
`61`		`- $prophecy = $this->prophet->prophesize($delegateBuilder->getFullyQualifiedClassName());`
`62`		`- $this->revelations[] = new Revelation($this->namespace, $functionName, $prophecy);`
	`59`	`+ foreach ($this->revelations as $revelation) {`
	`60`	`+ if (`
	`61`	`+ $revelation->namespace === $this->namespace`
	`62`	`+ && $revelation->functionName === $functionName`
	`63`	`+ ) {`
	`64`	`+ $prophecy = $revelation->prophecy;`
	`65`	`+ break;`
	`66`	`+ }`
	`67`	`+ }`
	`68`	`+`
	`69`	`+ if (! isset($prophecy)) {`
	`70`	`+ $delegateBuilder = new MockDelegateFunctionBuilder();`
	`71`	`+ $delegateBuilder->build($functionName);`
	`72`	`+ $prophecy = $this->prophet->prophesize($delegateBuilder->getFullyQualifiedClassName());`
	`73`	`+ $this->revelations[] = new Revelation($this->namespace, $functionName, $prophecy);`
	`74`	`+ }`
	`75`	`+`
`63`	`76`	`return $prophecy->__call(MockDelegateFunctionBuilder::METHOD, $arguments);`
`64`	`77`	`}`
`65`	`78`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,19 +18,22 @@ final class Revelation implements ProphecyInterface`
`18`	`18`	`{`
`19`	`19`
`20`	`20`	`/**`
	`21`	`+ * @internal`
`21`	`22`	`* @var string The function namespace.`
`22`	`23`	`*/`
`23`		`- private $namespace;`
	`24`	`+ public $namespace;`
`24`	`25`
`25`	`26`	`/**`
	`27`	`+ * @internal`
`26`	`28`	`* @var string The function name.`
`27`	`29`	`*/`
`28`		`- private $functionName;`
	`30`	`+ public $functionName;`
`29`	`31`
`30`	`32`	`/**`
	`33`	`+ * @internal`
`31`	`34`	`* @var ProphecyInterface The prophecy.`
`32`	`35`	`*/`
`33`		`- private $prophecy;`
	`36`	`+ public $prophecy;`
`34`	`37`
`35`	`38`	`/**`
`36`	`39`	`* Builds the revelation.`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,28 @@ protected function defineFunction($namespace, $functionName)`
`47`	`47`	`PHPProphet::define($namespace, $functionName);`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ public function testDoubleMockTheSameFunctionWithDifferentArguments()`
	`51`	`+ {`
	`52`	`+ $prophecy = $this->prophet->prophesize(__NAMESPACE__);`
	`53`	`+ $prophecy->min(1, 10)->willReturn(0);`
	`54`	`+ $prophecy->min(20, 30)->willReturn(1);`
	`55`	`+ $prophecy->reveal();`
	`56`	`+`
	`57`	`+ $this->assertSame(0, min(1, 10));`
	`58`	`+ $this->assertSame(1, min(20, 30));`
	`59`	`+ }`
	`60`	`+`
	`61`	`+ public function testTwoDifferentFunctionsMock()`
	`62`	`+ {`
	`63`	`+ $prophecy = $this->prophet->prophesize(__NAMESPACE__);`
	`64`	`+ $prophecy->min(1, 10)->willReturn(0);`
	`65`	`+ $prophecy->max(20, 30)->willReturn(1);`
	`66`	`+ $prophecy->reveal();`
	`67`	`+`
	`68`	`+ $this->assertSame(0, min(1, 10));`
	`69`	`+ $this->assertSame(1, max(20, 30));`
	`70`	`+ }`
	`71`	`+`
`50`	`72`	`/**`
`51`	`73`	`* This test is skipped until PHPUnit#2016 is resolved.`
`52`	`74`	`*`

Comments

(0)