Commit 2b0a3b0

authored

Update Knapsack.java

Changed OR condition to &&, OR may possibly result in ArrayIndexOutOfBoundException , (as it does for following input capacity : 60, weights: [10, 20, 33], values: [10, 3, 30])

1 parent 2adccbd commit 2b0a3b0Copy full SHA for 2b0a3b0

File tree

1 file changed

-1

lines changed

src/com/jwetherell/algorithms/mathematics
- Knapsack.java

1 file changed

-1

lines changed

`‎src/com/jwetherell/algorithms/mathematics/Knapsack.java‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public static final int[] zeroOneKnapsack(int[] values, int[] weights, int capac`
`40`	`40`	`final List<Integer> list = new ArrayList<Integer>();`
`41`	`41`	`int i = height - 1;`
`42`	`42`	`int j = width - 1;`
`43`		`- while (i != 0 \|\| j != 0) {`
	`43`	`+ while (i != 0 && j != 0) {`
`44`	`44`	`int current = output[i][j];`
`45`	`45`	`int above = output[i - 1][j];`
`46`	`46`	`if (current == above) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 2b0a3b0

File tree

1 file changed

1 file changed

`‎src/com/jwetherell/algorithms/mathematics/Knapsack.java‎`

0 commit comments