-
Notifications
You must be signed in to change notification settings - Fork 25
Search docs #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search docs #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start at capturing our process. I wouldn't mind an example of the config file, and I think we should consider adding a name property to each search node in that config.
It would be good to add a bit of description at the start describing how arranger will support local and network search and that this document describes how network search is setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what env flag? what does the flag set/enable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit confusing cause I read it assuming it meant local developer setup should have data available, but now I assume this is "local" in the context of "local search" vs "network search". This is a bit unclear.
Perhaps it could be phrased like Local Search configuration of this arranger node is performed separately from Network Search, since we do not require a local search config for network search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is file by default, but this is common for setups that use maestro to index files from song.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this here, we may want to include a name property to our node config. Arranger nodes aren't currently reporting a name of their own, so this would help us label each node in our responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should list the possible statuses and what they mean.
@ciaranschutte mermaid diag
6b33e90 to
7f882d1
Compare
3ba8dc7 to
52ed91e
Compare
Uh oh!
There was an error while loading. Please reload this page.
adding design doc in this location is temporary. there is an existing docs folder that needs some attention on what to do with it.
initial design doc for federated search
preferring the term "search_node" over "node" when talking about gql as there is already "node" data in Arranger
view PR in "rich diff" to display as rendered markdown