|
1 | 1 | ## What does this merge request do? |
2 | 2 |
|
3 | | -<!--TODO Link associated issue from title, like: <title> objectbox-java#NUMBER--> |
| 3 | +TODO Link associated issue from title, like: `<title> objectbox-java#NUMBER` |
4 | 4 |
|
5 | | -<!--TODO Briefly list what this merge request is about--> |
| 5 | +TODO Briefly list what this merge request is about |
6 | 6 |
|
7 | 7 | ## Author's checklist |
8 | 8 |
|
9 | 9 | - [ ] This merge request fully addresses the requirements of the associated task |
10 | 10 | - [ ] I did a self-review of the changes and did not spot any issues, among others: |
11 | | - - I added unit tests for new or changed behavior; existing and new tests pass |
12 | | - - My code conforms to our coding standards and guidelines |
13 | | - - My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer |
| 11 | + - I added unit tests for new or changed behavior; existing and new tests pass |
| 12 | + - My code conforms to our coding standards and guidelines |
| 13 | + - My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer |
14 | 14 | - [ ] I amended the objectbox-java changelog if this affects users in any way |
15 | 15 | - [ ] I assigned a reviewer to request review |
16 | 16 |
|
17 | 17 | ## Reviewer's checklist |
18 | 18 |
|
19 | | -- [ ] I reviewed all changes line-by-line and addressed relevant issues |
| 19 | +- [ ] I reviewed all changes line-by-line and addressed relevant issues. However: |
| 20 | + - for quickly resolved issues, I considered creating a fixup commit and discussing that, and |
| 21 | + - instead of many or long comments, I considered a meeting with or a draft commit for the author. |
20 | 22 | - [ ] The requirements of the associated task are fully met |
21 | 23 | - [ ] I can confirm that: |
22 | | - - CI passes |
23 | | - - If applicable, coverage percentages do not decrease |
24 | | - - New code conforms to standards and guidelines |
25 | | - - If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses) |
| 24 | + - CI passes |
| 25 | + - If applicable, coverage percentages do not decrease |
| 26 | + - New code conforms to standards and guidelines |
| 27 | + - If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses) |
0 commit comments