Commit 433712e

committed

Generator: always find ToOne backlink source by ToOne field name #130

With recent changes the model has the name of the ToOne field stored in relationField, so just always use it to look up the target ID (or relation) property.

1 parent 42caccc commit 433712eCopy full SHA for 433712e

File tree

2 files changed

+10

-15

lines changed

generator
- lib/src
  - code_builder.dart
- test
  - code_builder_test.dart

2 files changed

+10

-15

lines changed

`‎generator/lib/src/code_builder.dart‎`

Lines changed: 9 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,11 @@ class CodeBuilder extends Builder {`
`413`	`413`	`);`
`414`	`414`	`}`
`415`	`415`
	`416`	`+ // Note that in the model only the target ID (or relation) property of a`
	`417`	`+ // ToOne exists, so search for that.`
`416`	`418`	`if (bl.srcField.isEmpty) {`
	`419`	`+ // No source field name given, try to find the source relation by type of`
	`420`	`+ // its target entity.`
`417`	`421`	`final matchingProps = srcEntity.properties.where(`
`418`	`422`	`(p) => p.isRelation && p.relationTarget == entity.name,`
`419`	`423`	`);`
`@@ -429,17 +433,12 @@ class CodeBuilder extends Builder {`
`429`	`433`	`srcRel = matchingRels.first;`
`430`	`434`	`}`
`431`	`435`	`} else {`
`432`		`- // For backwards compatibility, expect the name of the ToOne field, so add`
`433`		`- // an "Id" suffix to find the target ID property.`
	`436`	`+ // Source field name given`
	`437`	`+ // For ToOne, expect the name of the ToOne field`
`434`	`438`	`srcProp = srcEntity.properties.firstWhereOrNull(`
`435`		`- (p) => p.isRelation && p.name == '${bl.srcField}Id',`
	`439`	`+ (p) => p.isRelation && p.relationField == bl.srcField,`
`436`	`440`	`);`
`437`		`- // Otherwise, and to support ToOne with renamed target ID properties`
`438`		`- // (using @TargetIdProperty), expect the name of the target ID property.`
`439`		`- srcProp ??= srcEntity.properties.firstWhereOrNull(`
`440`		`- (p) => p.isRelation && p.name == bl.srcField,`
`441`		`- );`
`442`		`- // For ToMany, always expect the name of the ToMany field/relation`
	`441`	`+ // For ToMany, expect the name of the ToMany field`
`443`	`442`	`srcRel = srcEntity.relations.firstWhereOrNull(`
`444`	`443`	`(r) => r.name == bl.srcField,`
`445`	`444`	`);`
`@@ -458,10 +457,7 @@ class CodeBuilder extends Builder {`
`458`	`457`	`} else {`
`459`	`458`	`throw InvalidGenerationSourceError(`
`460`	`459`	`'Failed to find backlink source for "${entity.name}.${bl.name}" in "${srcEntity.name}", '`
`461`		`- 'make sure a matching ToOne or ToMany relation exists.'`
`462`		`- ' If the ToOne target ID property is renamed with @TargetIdProperty,'`
`463`		`- ' then make sure to specify the name of the target ID property instead of the ToOne,'`
`464`		`- " like @Backlink('<property>').",`
	`460`	`+ 'make sure a matching ToOne or ToMany relation exists.',`
`465`	`461`	`);`
`466`	`462`	`}`
`467`	`463`	`}`

`‎generator/test/code_builder_test.dart‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -501,8 +501,7 @@ void main() {`
`501`	`501`	`@Id()`
`502`	`502`	`int id = 0;`
`503`	`503`
`504`		`- // Must specify the target ID property instead of the ToOne field`
`505`		`- @Backlink('customerRef')`
	`504`	`+ @Backlink('customer')`
`506`	`505`	`final backRel = ToMany<Example>();`
`507`	`506`	`}`
`508`	`507`	`''';`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 433712e

File tree

2 files changed

2 files changed

`‎generator/lib/src/code_builder.dart‎`

`‎generator/test/code_builder_test.dart‎`

0 commit comments