-
Notifications
You must be signed in to change notification settings - Fork 536
STY: Apply ruff/flake8-comprehensions rules (C4) #3680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3680 +/- ## ======================================= Coverage 70.86% 70.87% ======================================= Files 1276 1276 Lines 59229 59233 +4 Branches 9812 9796 -16 ======================================= + Hits 41975 41979 +4 - Misses 16079 16084 +5 + Partials 1175 1170 -5 ☔ View full report in Codecov by Sentry. |
8b4c8ef to
f81392c
Compare
215576c to
0fdc45e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of comments. Hopefully not overlapping with other rules...
565ca25 to
2685c02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One final suggestion.
C400 Unnecessary generator (rewrite as a `list` comprehension)
C409 Unnecessary `list` literal passed to `tuple()` (rewrite as a `tuple` literal)
C414 Unnecessary `list` call
C416 Unnecessary `list` comprehension (rewrite using `list()`)
C419 Unnecessary list comprehension
2685c02 to
679123a
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
679123a to
1747356
Compare
Summary
Apply flake8-comprehensions (C4) rules, except: