Commit f0a9d4c

authored

Merge pull request #3 from eerikson/AllowArbitraryPropsOnScriptEl

Assign attrs to created script element

2 parents 518c0d2 + 2556a05 commit f0a9d4cCopy full SHA for f0a9d4c

File tree

+2033

-2

lines changed

+2033

-2

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,16 @@ loadScript('https://example.com/script.js')`
`25`	`25`	`})`
`26`	`26`	```
`27`	`27`
	`28`	`+Additional attributes`
	`29`	`+`
	`30`	+```js
	`31`	`+var loadScript = require('tiny-script-loader/loadScript')`
	`32`	`+var loadScriptPromised = require('tiny-script-loader/loadScriptPromised')`
	`33`	`+`
	`34`	`+loadScript('https://example.com/script.js', callbackFn, { crossOrigin: true })`
	`35`	`+loadScriptPromised('https://example.com/script.js', { type: 'javascript' })`
	`36`	`+ .then(fn)`
	`37`	+```
`28`	`38`	`## License`
`29`	`39`
`30`	`40`	`[Apache-2.0](/LICENSE)`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,15 @@`
`1`		`-module.exports = function loadScript (src, cb) {`
	`1`	`+module.exports = function loadScript (src, cb,attrs) {`
`2`	`2`	`var doc = document`
`3`	`3`	`var tag = 'script'`
`4`	`4`	`var firstScript`
`5`	`5`	`var el`
`6`	`6`	`el = doc.createElement(tag)`
`7`	`7`	`firstScript = doc.getElementsByTagName(tag)[0]`
	`8`	`+ if (attrs) {`
	`9`	`+ Object.keys(attrs).forEach(function (key) {`
	`10`	`+ el[key] = attrs[key]`
	`11`	`+ })`
	`12`	`+ }`
`8`	`13`	`el.async = 1`
`9`	`14`	`el.src = src`
`10`	`15`	`el.onload = function () { cb() }`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,16 @@`
`1`		`-module.exports = function loadScriptPromised (src) {`
	`1`	`+module.exports = function loadScriptPromised (src,attrs) {`
`2`	`2`	`var doc = document`
`3`	`3`	`var tag = 'script'`
`4`	`4`	`var firstScript`
`5`	`5`	`var el`
`6`	`6`	`return new Promise(function (resolve, reject) {`
`7`	`7`	`el = doc.createElement(tag)`
`8`	`8`	`firstScript = doc.getElementsByTagName(tag)[0]`
	`9`	`+ if (attrs) {`
	`10`	`+ Object.keys(attrs).forEach(function (key) {`
	`11`	`+ el[key] = attrs[key]`
	`12`	`+ })`
	`13`	`+ }`
`9`	`14`	`el.async = 1`
`10`	`15`	`el.src = src`
`11`	`16`	`el.onload = function () { resolve() }`

Comments

(0)