Commit 3ac7844

committed

Free large cached payloads. Fixes #1587

If the ServerSession's payload cache has grown larger than the maximum size of a single packet, free it when the session is returned to the pool so that the memory can be reclaimed.

1 parent b71eb01 commit 3ac7844Copy full SHA for 3ac7844

File tree

1 file changed

-0

lines changed

src/MySqlConnector/Core
- ServerSession.cs

1 file changed

-0

lines changed

`‎src/MySqlConnector/Core/ServerSession.cs‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,11 @@ public ValueTask ReturnToPoolAsync(IOBehavior ioBehavior, MySqlConnection? ownin`
`74`	`74`	`LastReturnedTimestamp = Stopwatch.GetTimestamp();`
`75`	`75`	`if (Pool is null)`
`76`	`76`	`return default;`
	`77`	`+`
	`78`	`+ // if the payload cache is too large, discard it rather than keeping it alive in the pool; see https://github.com/mysql-net/MySqlConnector/issues/1587`
	`79`	`+ if (m_payloadCache.Array?.Length > ProtocolUtility.MaxPacketSize + 1)`
	`80`	`+ m_payloadCache.ArraySegment = default;`
	`81`	`+`
`77`	`82`	`MetricsReporter.RecordUseTime(Pool, Utility.GetElapsedSeconds(LastLeasedTimestamp, LastReturnedTimestamp));`
`78`	`83`	`LastLeasedTimestamp = 0;`
`79`	`84`	`return Pool.ReturnAsync(ioBehavior, this);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3ac7844

File tree

1 file changed

1 file changed

`‎src/MySqlConnector/Core/ServerSession.cs‎`

0 commit comments