Commit 1c72726

committed

Ensure having a correct foreign key query: using join with table name

The main reason is MariaDB 12.1 change https://jira.mariadb.org/browse/MDEV-28933 other language driver always use this : * [java mysql](https://github.com/mysql/mysql-connector-j/blob/d680767849154c8e136dfc3d8a0ae4d9fefd1fb7/src/main/user-impl/java/com/mysql/cj/jdbc/DatabaseMetaDataInformationSchema.java#L65) * [java mariadb](https://github.com/mariadb-corporation/mariadb-connector-j/blob/5222bfb7b30f8bcb71447b03d86843e872d19ec2/src/main/java/org/mariadb/jdbc/DatabaseMetaData.java#L1252) * [mysql ODBC](https://github.com/mysql/mysql-connector-odbc/blob/3d85084e3f70b4869e64a5d0b76447011232042b/driver/catalog.cc#L1642 * ... Signed-off-by: Diego Dupin <diego.dupin@mariadb.com>

1 parent cffaecc commit 1c72726Copy full SHA for 1c72726

File tree

1 file changed

-10

lines changed

src/MySqlConnector/Core
- SchemaProvider.cs

1 file changed

-10

lines changed

`‎src/MySqlConnector/Core/SchemaProvider.cs‎`

Lines changed: 9 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -446,15 +446,14 @@ private Task DoFillForeignKeysAsync(IOBehavior ioBehavior, DataTable dataTable,`
`446`	`446`	`command.CommandText = """`
`447`	`447`	`SELECT rc.constraint_catalog, rc.constraint_schema, rc.constraint_name,`
`448`	`448`	`kcu.table_catalog, kcu.table_schema,`
`449`		`- rc.table_name, rc.match_option, rc.update_rule, rc.delete_rule,`
`450`		`- NULL as referenced_table_catalog, kcu.referenced_table_schema, rc.referenced_table_name`
	`449`	`+ rc.table_name, rc.match_option, rc.update_rule, rc.delete_rule,`
	`450`	`+ NULL as referenced_table_catalog, kcu.referenced_table_schema, rc.referenced_table_name`
`451`	`451`	`FROM INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTS rc`
`452`		`- LEFT JOIN INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu ON`
`453`		`- (`
`454`		`- (kcu.constraint_catalog = rc.constraint_catalog OR (kcu.constraint_catalog IS NULL AND rc.constraint_catalog IS NULL)) AND`
`455`		`- (kcu.constraint_schema = rc.constraint_schema OR (kcu.constraint_schema IS NULL AND rc.constraint_schema IS NULL)) AND`
`456`		`- (kcu.constraint_name = rc.constraint_name OR (kcu.constraint_name IS NULL AND rc.constraint_name IS NULL))`
`457`		`- )`
	`452`	`+ LEFT JOIN INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu`
	`453`	`+ ON kcu.constraint_catalog = rc.constraint_catalog`
	`454`	`+ AND kcu.constraint_schema = rc.constraint_schema`
	`455`	`+ AND kcu.table_name = rc.table_name`
	`456`	`+ AND kcu.constraint_name = rc.constraint_name`
`458`	`457`	`WHERE kcu.ORDINAL_POSITION = 1`
`459`	`458`	`""";`
`460`	`459`
`@@ -481,9 +480,9 @@ private Task DoFillIndexesAsync(IOBehavior ioBehavior, DataTable dataTable, stri`
`481`	`480`	`command.CommandText = """`
`482`	`481`	`SELECT null AS INDEX_CATALOG, INDEX_SCHEMA,`
`483`	`482`	`INDEX_NAME, TABLE_NAME,`
`484`		- !NON_UNIQUE as `UNIQUE`,
	`483`	+ !NON_UNIQUE as `UNIQUE`,
`485`	`484`	INDEX_NAME='PRIMARY' as `PRIMARY`,
`486`		`- INDEX_TYPE as TYPE, COMMENT`
	`485`	`+ INDEX_TYPE as TYPE, COMMENT`
`487`	`486`	`FROM INFORMATION_SCHEMA.STATISTICS`
`488`	`487`	`WHERE SEQ_IN_INDEX=1`
`489`	`488`	`""";`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 1c72726

File tree

1 file changed

1 file changed

`‎src/MySqlConnector/Core/SchemaProvider.cs‎`

0 commit comments