Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Translated to Traditional Chinese #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doggy8088 wants to merge 2 commits into mybatis:master
base: master
Choose a base branch
Loading
from doggy8088:patch-1

Conversation

@doggy8088
Copy link

@doggy8088 doggy8088 commented Jun 18, 2022

No description provided.

Copy link

@Ives19880122 Ives19880122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@tzkp tzkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Yuno-Liu Yuno-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@HugoUno HugoUno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@HugoUno HugoUno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bessonlin bessonlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Oliver721003 Oliver721003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fang5502 fang5502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@iankingh iankingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

LGTM

Copy link

@Wonsle Wonsle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Coolred Coolred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@xiulolz xiulolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Did you guys verify the result of mvn clean site?
I don't see a directory for zh_TW in target/site.

Copy link
Author

doggy8088 commented Jun 21, 2022 •
edited
Loading

@harawata Is there any translation guideline? I don't know how to do it right.

Should I modify pom.xml file for new language?

Copy link
Contributor

@awxiaoxian2020 awxiaoxian2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add zh_TW in pom.xml for maven site plugin

doggy8088 reacted with thumbs up emoji
Copy link
Author

doggy8088 commented Jun 21, 2022 •
edited
Loading

I added. There is still no zh-tw appear in target/site folder after run mvn site.

image

Here is my folder structure:

image

The log shown:

image

It seems look for zh which is wrong. I don't know how to do it right.

Copy link
Author

doggy8088 commented Jun 21, 2022 •
edited
Loading

I tried so many ways to generate zh_TW locale for the site. Still failed. Anyone can help? :(

Copy link
Author

doggy8088 commented Jun 21, 2022 •
edited
Loading

I think this issue is caused by Apache Maven Site Plugin. I created a bug report here: https://issues.apache.org/jira/browse/MSITE-904

harawata and puppylpg reacted with thumbs up emoji

<td><code>parameterType</code></td>
<td>
將會傳入這條語句的參數的類別全限定名或別名。這個屬性是可選的,因為
MyBatis 可以透過型別處理器(TypeHandler)推斷出具體傳入語句的參數,預設值為未設定(unset)。
Copy link
Contributor

@puppylpg puppylpg Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2836 same error here

<td><code>parameterType</code></td>
<td>
將會傳入這條語句的參數的類別全限定名或別名。這個屬性是可選的,因為
MyBatis 可以透過型別處理器(TypeHandler)推斷出具體傳入語句的參數,預設值為未設定(unset)。
Copy link
Contributor

@puppylpg puppylpg Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2836 +1

Copy link
Contributor

It seems we could work on this issue now.
doggy8088 reacted with heart emoji

Copy link
Author

@awxiaoxian2020 Are you able to support different zh locale now?

Copy link
Contributor

I just notice that we have moved maven site 4.
doggy8088 reacted with laugh emoji

Copy link
Author

So I should send another PR, right?

Copy link
Contributor

You can just resolve the conflict I think.

Copy link
Author

doggy8088 commented Feb 23, 2024 •
edited
Loading

@awxiaoxian2020 I'm struggling with the build process. I tried to build mybatis-3 project in the docker container:

docker run -it --rm --name=mybatis maven:3-eclipse-temurin-11 bash

I git clone the repo and checkout the master branch. Then I run the following commands. (Reference from your GitHub Actions)

git clone https://github.com/mybatis/mybatis-3.git --depth=1
cd mybatis-3
ARG_LINE=-D"argLine=--illegal-access=permit"
./mvnw test -B -V --no-transfer-progress -D"license.skip=true" -D"jacoco.skip=true" $ARG_LINE
./mvnw help:active-profiles
./mvnw site site:stage -DskipTests -B -V --no-transfer-progress -Dlicense.skip=true

Then I'll get the following errors:

5 errors
40 warnings
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:06 min
[INFO] Finished at: 2024年02月24日T17:23:01Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:4.0.0-M13:site (default-site) on project mybatis: Error generating maven-javadoc-plugin:3.6.3:javadoc report:
[ERROR] Exit code: 1
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:28: error: self-closing element not allowed
[ERROR] * <b>How to use:</b> <br/>
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:44: error: bad use of '>'
[ERROR] * &#064;Select({ "&lt;script>", "select * from users", "where name = #{name}",
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR] * "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR] * "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/annotations/Select.java:45: error: bad use of '>'
[ERROR] * "&lt;if test=\"age != null\"> age = #{age} &lt;/if>", "&lt;/script>" })
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/builder/MapperBuilderAssistant.java:271: warning: no @param for resultSets
[ERROR] public MappedStatement addMappedStatement(String id, SqlSource sqlSource, StatementType statementType,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:844: warning: no @return
[ERROR] public Collection<XMLStatementBuilder> getIncompleteStatements() {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:861: warning: no @return
[ERROR] public Collection<CacheRefResolver> getIncompleteCacheRefs() {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:878: warning: no @return
[ERROR] public Collection<ResultMapResolver> getIncompleteResultMaps() {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/session/Configuration.java:904: warning: no @return
[ERROR] public Collection<MethodResolver> getIncompleteMethods() {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @param for expression
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @param for parameterObject
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:46: warning: no @return
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for expression
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for parameterObject
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @param for nullable
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ExpressionEvaluator.java:53: warning: no @return
[ERROR] public Iterable<?> evaluateIterable(String expression, Object parameterObject, boolean nullable) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for configuration
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for contents
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for collectionExpression
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for index
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for item
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for open
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for close
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:46: warning: no @param for separator
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, String index,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for configuration
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for contents
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for collectionExpression
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for nullable
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for index
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for item
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for open
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for close
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/scripting/xmltags/ForEachSqlNode.java:54: warning: no @param for separator
[ERROR] public ForEachSqlNode(Configuration configuration, SqlNode contents, String collectionExpression, Boolean nullable,
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for <K>
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for <V>
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for map
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for key
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @param for mappingFunction
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:31: warning: no @return
[ERROR] public static <K, V> V computeIfAbsent(Map<K, V> map, K key, Function<K, V> mappingFunction) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for <K>
[ERROR] public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for <V>
[ERROR] public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for key
[ERROR] public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @param for value
[ERROR] public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR] ^
[ERROR] /mybatis-3/src/main/java/org/apache/ibatis/util/MapUtil.java:42: warning: no @return
[ERROR] public static <K, V> Entry<K, V> entry(K key, V value) {
[ERROR] ^
[ERROR] Command line was: /opt/java/openjdk/bin/javadoc @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/mybatis-3/target/site/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Do you know how to fix it?

Copy link
Member

@doggy8088 Javadocs are rather misleading. Ignore the [error] on left as its hiding real issue. Instead look at the right hand side. Bulk of those are warnings which is ok. There is an error on the right though that does need fixed.

Also if you could fix your merge conflicts while at it.

Copy link
Author

I just want to make sure I can build this project before I contribute translations.

Why you haven't met this issue?

Copy link
Member

hazendaz commented Mar 1, 2024

Your branch is conflicted, its failing because its conflicted. Try fixing your conflicts and try again.

Copy link
Author

@hazendaz I know it's conflicting. I'm not building my branch. I'm building master branch. I want to build it before I fix the conflicts.

Copy link
Member

hazendaz commented Mar 2, 2024

Master builds fine against the following https://github.com/mybatis/mybatis-3/blob/master/.github/workflows/ci.yaml, what problem are you having exactly? jdk 11 is required at a minimum to build. The item mentioned above from you earlier I presume was this build. However, I see you changed no source so that is odd. Its a javadoc issue. Its clear what it is there but its not failing on our master. If you have some time, take a look at what you are seeing there and if really issue on our end, please send a PR to fix. It looks trivial but unclear to me at the moment why you would see that but we don't.

Copy link
Member

hazendaz commented Mar 2, 2024

It is during site so it could be related to this change, are you saying master is doing that from the site?

Copy link
Member

hazendaz commented Jan 1, 2025

@doggy8088 Can you resolve the merge conflicts to see if this can progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

16 more reviewers

@xiulolz xiulolz xiulolz left review comments

@puppylpg puppylpg puppylpg left review comments

@Oliver721003 Oliver721003 Oliver721003 left review comments

@iankingh iankingh iankingh left review comments

@Coolred Coolred Coolred left review comments

@Oliverwqcwrw Oliverwqcwrw Oliverwqcwrw requested changes

@awxiaoxian2020 awxiaoxian2020 awxiaoxian2020 requested changes

@Wonsle Wonsle Wonsle approved these changes

@sheraium sheraium sheraium approved these changes

@HugoUno HugoUno HugoUno approved these changes

@fang5502 fang5502 fang5502 approved these changes

@bessonlin bessonlin bessonlin approved these changes

@tzkp tzkp tzkp approved these changes

@Ives19880122 Ives19880122 Ives19880122 approved these changes

@Yuno-Liu Yuno-Liu Yuno-Liu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌏 doc-zh Up for contributors' review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /