Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor our redundant Lua API functions to use templates #1765

Open
Labels
@Pirulax

Description

Is your feature request related to a problem? Please describe.
There are 2 places where we have copy pasted code that can be easily "templateized":

  • CLuaArgument - PushACL, PushElement`, etc..
  • LuaCommon - Ex.: lua_pushacl, lua_pushelement, etc..

Describe the solution you'd like
We can use some generic programming magic (aka templates)

Describe alternatives you've considered
Leave it like it is

Additional context
We can use Visual Studio's Edit->Refactor option. It's really convenient, this issue can be solved in an hour (or ideally less)
I don't think following Lua's convention is necessary, as it just adds redundant code. Lua has different function names, because C doesn't have templates, but this ain't C, but C++, so... We might as well make use of it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /