Commit 37eb67c

committed

Exclude methods inherited from traits in PedantryTest

This commit also uses dataset names for better visibility during debugging

1 parent cf3a5ea commit 37eb67cCopy full SHA for 37eb67c

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,8 @@ public function testMethodsAreOrderedAlphabeticallyByVisibility($className): voi`
`33`	`33`	`$methods = array_filter(`
`34`	`34`	`$methods,`
`35`	`35`	`function (ReflectionMethod $method) use ($class) {`
`36`		`- return $method->getDeclaringClass() == $class;`
	`36`	`+ return $method->getDeclaringClass() == $class // Exclude inherited methods`
	`37`	`+ && $method->getFileName() === $class->getFileName(); // Exclude methods inherited from traits`
`37`	`38`	`}`
`38`	`39`	`);`
`39`	`40`
`@@ -86,7 +87,8 @@ public function provideProjectClassNames()`
`86`	`87`	`continue;`
`87`	`88`	`}`
`88`	`89`
`89`		`- $classNames[][] = 'MongoDB\\' . str_replace(DIRECTORY_SEPARATOR, '\\', substr($file->getRealPath(), strlen($srcDir) + 1, -4));`
	`90`	`+ $className = 'MongoDB\\' . str_replace(DIRECTORY_SEPARATOR, '\\', substr($file->getRealPath(), strlen($srcDir) + 1, -4));`
	`91`	`+ $classNames[$className][] = $className;`
`90`	`92`	`}`
`91`	`93`
`92`	`94`	`return $classNames;`

Comments

(0)