Commit cd1622e

committed

Check for _id extraction before appending insert

1 parent 7d092b7 commit cd1622eCopy full SHA for cd1622e

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -437,18 +437,18 @@ static PHP_METHOD(MongoDB_Driver_BulkWriteCommand, insertOne)`
`437`	`437`	`goto cleanup;`
`438`	`438`	`}`
`439`	`439`
	`440`	`+ if (!bson_out) {`
	`441`	`+ phongo_throw_exception(PHONGO_ERROR_LOGIC, "php_phongo_zval_to_bson() did not return an _id. Please file a bug report.");`
	`442`	`+ goto cleanup;`
	`443`	`+ }`
	`444`	`+`
`440`	`445`	`if (!mongoc_bulkwrite_append_insertone(intern->bw, ns, &bdocument, NULL, &error)) {`
`441`	`446`	`phongo_throw_exception_from_bson_error_t(&error);`
`442`	`447`	`goto cleanup;`
`443`	`448`	`}`
`444`	`449`
`445`	`450`	`intern->num_ops++;`
`446`	`451`
`447`		`- if (!bson_out) {`
`448`		`- phongo_throw_exception(PHONGO_ERROR_LOGIC, "php_phongo_zval_to_bson() did not return document identifier. Please file a bug report.");`
`449`		`- goto cleanup;`
`450`		`- }`
`451`		`-`
`452`	`452`	`phongo_bwc_extract_id(bson_out, &return_value);`
`453`	`453`
`454`	`454`	`cleanup:`

Comments

(0)