3.8.x continuous matrix testing #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jyemin wants to merge 13 commits into mongodb:3.8.x from jyemin:3.8.x-continuous-matrix-testing

Closed

3.8.x continuous matrix testing #653

jyemin wants to merge 13 commits into mongodb:3.8.x from jyemin:3.8.x-continuous-matrix-testing

Conversation

@jyemin

Copy link

Collaborator

@jyemin jyemin commented Jan 29, 2021 •

edited

Loading

This is a patch to the 3.8.x branch to fulfill the goals for continuous matrix testing for the 4.0-era driver, which was 3.8.0. Similar PRs will be done for the 4.2 and 4.4 era release branches. What I've done here is two things:

Modify or skip tests that will not pass against later server versions. Mostly because the features under test have been removed
In cases where the server made breaking changes to commands that prevents the driver code from working, I changed the driver code to make it work with the later server versions. This seemed easier than disabling all the tests of that feature, though that is another option we could consider. Look at the changes to MapReduceToCollectionOperation for an example of this.

There's nothing really new here. All these changes have been applied already in one form or another to the master branch of the driver. It was just a matter of finding them and copying them to this branch.

JAVA-3942

Full patch build: https://spruce.mongodb.com/version/60133b4d9ccd4e019373ad0d/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

jyemin added 13 commits

January 27, 2021 18:13

@jyemin


 Fix or disable tests that fail against MongoDB 4.2

e983feb

JAVA-3942

@jyemin


 Disable test for change stream projecting out the _id field

ad624f4

There's an integration test that asserts an exception is thrown when a change stream
projects out the _id field. Running against 3.6 and 4.0, this condition is checked
in the driver itself while processing the results. But in 4.4 the server started
replying with an error on the getMore in this scenario. A newer driver would know not to
retry in this case, because newer drivers implemented an allow list for resumeable change
stream errors when the server version. But older drivers don't have that logic, so
it will treat this command error as retryable and never actually report the error.
JAVA-3942

@jyemin


 Make change stream operation integration test more robust

ed6ea84

JAVA-3942

@jyemin


 Disable $hint test for 4.2+ sharded clusters

a5a63f6

The reply format has changed in a way that breaks the test. This test
has been disabled in subsequent releases and ultimately just removed.
JAVA-3942

@jyemin


 Make mapReduce implementation compatible with 4.4

129d7db

JAVA-3942

@jyemin


 Make mapReduce tests compatible with 4.4

ab13eab

JAVA-3942

@jyemin


 Fix metaTextScore functional tests

f58395a

Change the test so that it produces a non-zero score so that the score
won't be excluded by later server versions.
JAVA-3942

@jyemin


 Add 4.4 to Evergreen matrix

3c49599

JAVA-3942

@jyemin


 Fix upload of Junit test results

424d17c

JAVA-3942

@jyemin


 Disable tests of geoHaystack indexes on 5.0+ servers

bddbb54

JAVA-3942

@jyemin


 Disable explain test for sharded clusters for 5.0 and up

34c7f43

JAVA-3942

@jyemin


 Add "latest" to Evergreen matrix

5a4de01

JAVA-3942

@jyemin


 Add COMPATIBILITY.MD

cfd33c6

JAVA-3942

jyemin

jyemin commented

Jan 29, 2021

View reviewed changes

.evergreen/.evg.yml

- command: attach.xunit_results

params:

file: ./src/*/build/test-results/TEST-*.xml

file: ./src/*/build/test-results/test/TEST-*.xml

Copy link

Collaborator Author

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test uploading was actually broken in the 3.x branch, so I just fixed it.

.evergreen/.evg.yml

${PREPARE_SHELL}

echo '{"results": [{ "status": "FAIL", "test_file": "Build", "log_raw": "No test-results.json found was created" } ]}' > ${PROJECT_DIRECTORY}/test-results.json

"install dependencies":

Copy link

Collaborator Author

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The presence of this function caused evergreen to refuse to load the file, so had to remove it.

Copy link

Member

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

driver-core/src/main/com/mongodb/operation/MapReduceHelper.java

}

private static int getInputCount(final BsonDocument result) {

return result.getDocument("counts").getNumber("input").intValue();

Copy link

Collaborator Author

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are to prevent the driver from failing when no statistics are present in the reply. Without this change, we can't run mapReduce operations at all.

Copy link

Member

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

driver-core/src/main/com/mongodb/operation/MapReduceToCollectionOperation.java

BsonDocument outputDocument = new BsonDocument(getAction(), new BsonString(getCollectionName()));

outputDocument.append("sharded", BsonBoolean.valueOf(isSharded()));

outputDocument.append("nonAtomic", BsonBoolean.valueOf(isNonAtomic()));

if (description != null && !serverIsAtLeastVersionFourDotFour(description)) {

Copy link

Collaborator Author

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, the server will fail to execute the operation

@jyemin jyemin requested a review from rozza

January 29, 2021 17:55

rozza

rozza requested changes

Feb 1, 2021

View reviewed changes

Copy link

Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but LGTM after that

.evergreen/.evg.yml

${PREPARE_SHELL}

echo '{"results": [{ "status": "FAIL", "test_file": "Build", "log_raw": "No test-results.json found was created" } ]}' > ${PROJECT_DIRECTORY}/test-results.json

"install dependencies":

Copy link

Member

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

driver-core/src/main/com/mongodb/operation/MapReduceHelper.java

}

private static int getInputCount(final BsonDocument result) {

return result.getDocument("counts").getNumber("input").intValue();

Copy link

Member

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

driver-core/src/main/com/mongodb/operation/MapReduceToCollectionOperation.java Show resolved Hide resolved

@jyemin

Copy link

Collaborator Author

jyemin commented Feb 1, 2021

Pushed to https://github.com/mongodb/mongo-java-driver/tree/3.8.x-continuous-matrix-testing

@jyemin jyemin closed this

Feb 1, 2021

Labels

None yet

2 participants

@jyemin @rozza

3.8.x continuous matrix testing #653

3.8.x continuous matrix testing #653

Uh oh!

Conversation

@jyemin jyemin commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

@jyemin jyemin Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

@rozza rozza left a comment

Choose a reason for hiding this comment

Uh oh!

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

@rozza rozza Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jyemin commented Feb 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

@jyemin jyemin commented Jan 29, 2021 •

edited

Loading