Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOCSP-44554: add more aggregation examples #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustagir merged 7 commits into mongodb:5.1 from rustagir:DOCSP-44554-agg-builder-examples
Feb 25, 2025

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Feb 12, 2025
edited
Loading

https://jira.mongodb.org/browse/DOCSP-44554

Adds more examples of using the aggregation builder

STAGING

Checklist

  • Add tests and ensure they pass

@rustagir rustagir force-pushed the DOCSP-44554-agg-builder-examples branch from ca9cc96 to 2de60ea Compare February 12, 2025 15:36
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 w/ 2 small comments

Copy link
Member

@GromNaN GromNaN left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice of examples.
I think the text is no longer correct.

Comment on lines +162 to +163
Query::gte(new UTCDateTime(new DateTimeImmutable('2014年01月01日'))),
Query::lt(new UTCDateTime(new DateTimeImmutable('2015年01月01日'))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could skip the new UTCDateTime part, but that's not possible due to type restrictions. https://jira.mongodb.org/browse/PHPLIB-1634

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When that ticket is resolved, we can always make the updates to the docs!

@rustagir rustagir merged commit f10f346 into mongodb:5.1 Feb 25, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN approved these changes

@norareidy norareidy norareidy approved these changes

@mongoKart mongoKart mongoKart approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /