-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Mutator can not handle array #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
GromNaN
requested changes
Oct 9, 2023
This comment was marked as resolved.
This comment was marked as resolved.
@GromNaN I think this would be fix this issue. Now it's supporting mutators that return [ key => value ] to change the key name and also mutators that return an array of values. I write tests for both to prevent any breaking changes in the future.
GromNaN
GromNaN
requested changes
Oct 15, 2023
So if the field's key can be an integer, this can't fix the problem and I think there is no way to solve this. Thank you for your time❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As mentioned in #2634, creating a mutator for the
arraytype attribute will throw an error while setting the value to the attribute. This error will be thrown because of the invalid value prepared for the update action. So I overridenormalizeCastClassResponsemethod fromIlluminate\Database\Eloquent\Concerns\HasAttributestrait and force it to add the key name all the time.So if we have something like this on our model class
we do not get an error anymore.