Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit f65d4a5

Browse files
authored
fix: Fix the problem that the previous demo cannot run properly (#3280)
1 parent d8add5d commit f65d4a5

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

‎federated-npm/app1/src/App.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import('app1')
2+
import('app3')
33
const RemoteButton = React.lazy(() => import('app2/Button'));
44
import lodash from 'lodash';
55
import merge from 'lodash.merge';

‎federated-npm/app1/webpack.config.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const remotes = {
88
}
99

1010
const delegatedRemote = {
11-
app3: "app1@http://localhost:3003/remoteEntry.js",
11+
app3: "app3@http://localhost:3003/remoteEntry.js",
1212
}
1313

1414
const delegatedRemotesObject = Object.entries(delegatedRemote).reduce((acc, [name, url]) => {

‎federated-npm/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"e2e:ci": "yarn start & wait-on http-get://localhost:3001/ && npx cypress run --config-file ../cypress/config/cypress.config.ts --config '{\"supportFile\": \"../cypress/support/e2e.ts\"}' --spec \"./e2e/*.cy.ts\" --browser=chrome"
1818
},
1919
"devDependencies": {
20-
"lerna": "3.22.1"
20+
"lerna": "3.22.1",
21+
"wait-on": "7.0.1"
2122
}
2223
}

‎loadable-react-16/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"e2e:ci": "yarn start & wait-on http-get://localhost:3000/ && npx cypress run --config-file ../cypress/config/cypress.config.ts --config '{\"supportFile\": \"../cypress/support/e2e.ts\"}' --spec \"./e2e/*.cy.ts\" --browser=chrome"
1515
},
1616
"devDependencies": {
17-
"lerna": "3.22.1"
17+
"lerna": "3.22.1",
18+
"wait-on": "7.0.1"
1819
}
1920
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /