-
-
Notifications
You must be signed in to change notification settings - Fork 320
refactor(test-runner-core): remove unused configFilePath option and TestSessionGroup type.
#2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inadvertently moved them to get added multiple times; reverting change
⚠️ No Changeset found
Latest commit: 75522a4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The primary purpose of this PR is to fix #2982. I removed the logic that makes test file discovery relative to the specified
configFilePath. Now the behavior is the same as when noconfigFilePathis specified, i.e. files are found relative to the working directory. After removing that logic, I realized theconfigFilePathoption was no longer used anywhere, so I removed it completely. This is a breaking change for anyone using that option. However, given that the option doesn't really do anything, this is probably of minimal impact.While familiarizing myself with the code base, I also noticed that the
sessionGroupsvariable is never used. Removing that and propagating the change through the code base ultimately led to the removal of the unusedTestSessionGrouptype and a change to theTestSessionManagerconstructor signature. These are also technically breaking changes for anyone who imports@web/test-runner-coredirectly.