Commit ac6a51d

authored

Merge pull request ryanmcdermott#182 from DavidVujic/liskov-substitution

Liskov Substitution (SOLID section) - width/height/length as constructor params

2 parents 47dbe9d + 90e9b24 commit ac6a51dCopy full SHA for ac6a51d

File tree

1 file changed

-28

lines changed

README.md

1 file changed

-28

lines changed

`‎README.md‎`

Lines changed: 7 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -1257,17 +1257,9 @@ class Shape {`
`1257`	`1257`	`}`
`1258`	`1258`
`1259`	`1259`	`class Rectangle extends Shape {`
`1260`		`- constructor() {`
	`1260`	`+ constructor(width, height) {`
`1261`	`1261`	`super();`
`1262`		`- this.width = 0;`
`1263`		`- this.height = 0;`
`1264`		`- }`
`1265`		`-`
`1266`		`- setWidth(width) {`
`1267`	`1262`	`this.width = width;`
`1268`		`- }`
`1269`		`-`
`1270`		`- setHeight(height) {`
`1271`	`1263`	`this.height = height;`
`1272`	`1264`	`}`
`1273`	`1265`
`@@ -1277,12 +1269,8 @@ class Rectangle extends Shape {`
`1277`	`1269`	`}`
`1278`	`1270`
`1279`	`1271`	`class Square extends Shape {`
`1280`		`- constructor() {`
	`1272`	`+ constructor(length) {`
`1281`	`1273`	`super();`
`1282`		`- this.length = 0;`
`1283`		`- }`
`1284`		`-`
`1285`		`- setLength(length) {`
`1286`	`1274`	`this.length = length;`
`1287`	`1275`	`}`
`1288`	`1276`
`@@ -1293,21 +1281,12 @@ class Square extends Shape {`
`1293`	`1281`
`1294`	`1282`	`function renderLargeShapes(shapes) {`
`1295`	`1283`	`shapes.forEach((shape) => {`
`1296`		`- switch (shape.constructor.name) {`
`1297`		`- case 'Square':`
`1298`		`- shape.setLength(5);`
`1299`		`- break;`
`1300`		`- case 'Rectangle':`
`1301`		`- shape.setWidth(4);`
`1302`		`- shape.setHeight(5);`
`1303`		`- }`
`1304`		`-`
`1305`		`- const area = shape.getArea();`
`1306`		`- shape.render(area);`
`1307`		`- });`
`1308`		`-}`
	`1284`	`+ const area = shape.getArea();`
	`1285`	`+ shape.render(area);`
	`1286`	`+ });`
	`1287`	`+ }`
`1309`	`1288`
`1310`		`-const shapes = [new Rectangle(), new Rectangle(), new Square()];`
	`1289`	`+const shapes = [new Rectangle(4, 5), new Rectangle(4, 5), new Square(5)];`
`1311`	`1290`	`renderLargeShapes(shapes);`
`1312`	`1291`	```
`1313`	`1292`	`[⬆ back to top](#table-of-contents)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ac6a51d

File tree

1 file changed

1 file changed

`‎README.md‎`

0 commit comments