-
Notifications
You must be signed in to change notification settings - Fork 27
STYLE: Linting ddbc_binding.cpp #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,090
−1,369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
the
pr-size: medium
Moderate update size
label
Oct 28, 2025
@github-actions
github-actions
bot
added
pr-size: large
Substantial code update
and removed
pr-size: medium
Moderate update size
labels
Oct 28, 2025
sumitmsft
sumitmsft
approved these changes
Oct 29, 2025
gargsaumya
gargsaumya
approved these changes
Oct 29, 2025
bewithgaurav
bewithgaurav
approved these changes
Oct 29, 2025
@jahnvi480
jahnvi480
merged commit Oct 31, 2025
87eb1f5
into
jahnvi/encode_decode_250
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Work Item / Issue Reference
Summary
This pull request primarily refactors the formatting and structure of the
mssql_python/pybind/ddbc_bindings.cppfile, focusing on code readability and maintainability. No functional logic changes are introduced; instead, the changes consist of improved line wrapping, consistent indentation, and clearer inline comments, especially in function definitions and pybind11 module bindings.Formatting and readability improvements:
FetchMany_wrap, pybind11 bindings) for better readability and consistency.Header and include adjustments: