Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

STYLE: Linting ddbc_binding.cpp #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahnvi480 merged 5 commits into jahnvi/encode_decode_250 from jahnvi/ddbc_linting
Oct 31, 2025

Conversation

@jahnvi480
Copy link
Contributor

@jahnvi480 jahnvi480 commented Oct 28, 2025
edited by azure-boards bot
Loading

Work Item / Issue Reference

AB#38478


Summary

This pull request primarily refactors the formatting and structure of the mssql_python/pybind/ddbc_bindings.cpp file, focusing on code readability and maintainability. No functional logic changes are introduced; instead, the changes consist of improved line wrapping, consistent indentation, and clearer inline comments, especially in function definitions and pybind11 module bindings.

Formatting and readability improvements:

  • Reformatted function signatures and argument lists in several places (e.g., FetchMany_wrap, pybind11 bindings) for better readability and consistency.
  • Improved line wrapping and indentation in conditional logic and function calls, making code easier to follow.
  • Enhanced inline comments, especially around LOB streaming and module-level UUID caching, for clarity.
  • Updated error logging during ODBC driver loading to use multi-line comments and clearer formatting.

Header and include adjustments:

  • Reordered and deduplicated header includes, grouping standard library headers and removing redundant imports.

@github-actions github-actions bot added the pr-size: medium Moderate update size label Oct 28, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: medium Moderate update size labels Oct 28, 2025
@jahnvi480 jahnvi480 merged commit 87eb1f5 into jahnvi/encode_decode_250 Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bewithgaurav bewithgaurav bewithgaurav approved these changes

@sumitmsft sumitmsft sumitmsft approved these changes

@gargsaumya gargsaumya gargsaumya approved these changes

Assignees

No one assigned

Labels

pr-size: large Substantial code update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /