Commit f72f3f1

barnsligdpgeorge

authored and

committed

lora-sx126x: Fix invert_iq_rx / invert_iq_tx behaviour.

This commit fixes a typo and changes a tuple that needs to be mutable to a list (because other parts of the code change elements of this list). Signed-off-by: Damien George <damien@micropython.org>

1 parent 221a877 commit f72f3f1Copy full SHA for f72f3f1

File tree

2 files changed

-4

lines changed

micropython/lora/lora-sx126x
- lora
  - sx126x.py
- manifest.py

2 files changed

-4

lines changed

`‎micropython/lora/lora-sx126x/lora/sx126x.py‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -363,11 +363,11 @@ def configure(self, lora_cfg):`
`363`	`363`	`if "preamble_len" in lora_cfg:`
`364`	`364`	`self._preamble_len = lora_cfg["preamble_len"]`
`365`	`365`
`366`		`- self._invert_iq = (`
	`366`	`+ self._invert_iq = [`
`367`	`367`	`lora_cfg.get("invert_iq_rx", self._invert_iq[0]),`
`368`	`368`	`lora_cfg.get("invert_iq_tx", self._invert_iq[1]),`
`369`	`369`	`self._invert_iq[2],`
`370`		`- )`
	`370`	`+ ]`
`371`	`371`
`372`	`372`	`if "freq_khz" in lora_cfg:`
`373`	`373`	`self._rf_freq_hz = int(lora_cfg["freq_khz"] * 1000)`
`@@ -449,7 +449,7 @@ def configure(self, lora_cfg):`
`449`	`449`	`def _invert_workaround(self, enable):`
`450`	`450`	`# Apply workaround for DS 15.4 Optimizing the Inverted IQ Operation`
`451`	`451`	`if self._invert_iq[2] != enable:`
`452`		`- val = self._read_read(_REG_IQ_POLARITY_SETUP)`
	`452`	`+ val = self._reg_read(_REG_IQ_POLARITY_SETUP)`
`453`	`453`	`val = (val & ~4) \| _flag(4, enable)`
`454`	`454`	`self._reg_write(_REG_IQ_POLARITY_SETUP, val)`
`455`	`455`	`self._invert_iq[2] = enable`

`‎micropython/lora/lora-sx126x/manifest.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-metadata(version="0.1.3")`
	`1`	`+metadata(version="0.1.4")`
`2`	`2`	`require("lora")`
`3`	`3`	`package("lora")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit f72f3f1

File tree

2 files changed

2 files changed

`‎micropython/lora/lora-sx126x/lora/sx126x.py‎`

`‎micropython/lora/lora-sx126x/manifest.py‎`

0 commit comments