Commit ad6ab5a

projectgusdpgeorge

authored and

committed

lora-sync: Fix race with fast or failed send().

If send completes before the first call to poll_send(), the driver could get stuck in _sync_wait(). This had much less impact before rp2 port went tickless, as _sync_wait(will_irq=True) calls machine.idle() which may not wake very frequently on a tickless port. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>

1 parent b712103 commit ad6ab5aCopy full SHA for ad6ab5a

File tree

2 files changed

-2

lines changed

micropython/lora/lora-sync
- lora
  - sync_modem.py
- manifest.py

2 files changed

-2

lines changed

`‎micropython/lora/lora-sync/lora/sync_modem.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,8 @@ def send(self, packet, tx_at_ms=None):`
`42`	`42`
`43`	`43`	`tx = True`
`44`	`44`	`while tx is True:`
`45`		`- tx = self.poll_send()`
`46`	`45`	`self._sync_wait(will_irq)`
	`46`	`+ tx = self.poll_send()`
`47`	`47`	`return tx`
`48`	`48`
`49`	`49`	`def recv(self, timeout_ms=None, rx_length=0xFF, rx_packet=None):`

`‎micropython/lora/lora-sync/manifest.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-metadata(version="0.1.0")`
	`1`	`+metadata(version="0.1.1")`
`2`	`2`	`require("lora")`
`3`	`3`	`package("lora")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ad6ab5a

File tree

2 files changed

2 files changed

`‎micropython/lora/lora-sync/lora/sync_modem.py‎`

`‎micropython/lora/lora-sync/manifest.py‎`

0 commit comments