Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 9056369

Browse files
Changed the default minimum height of screenshots.
1 parent 9bbe09b commit 9056369

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

‎ChangeLog.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change Log
22

3+
### 1.3.2 - 20108/10/24
4+
- Changed the default minimum height of screenshots.
5+
- Tweaked the layout.
6+
37
### 1.3.1 - 2018年10月24日
48
- Tweaked the layout.
59
- Fixed a bug which caused a PHP notice, undefined index with accessing `$_SERVER[ 'HTTP_USER_AGENT' ]` when it is not set.

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ It accepts the following values: `pdf`, `png`, `jpg`, `jpeg`, `bmp`, `ppm`.
6666
When `screenshot` is given for the `output` parameter, `width` sets the screenshot image width.
6767

6868
#### height
69-
When `screenshot` is given for the `output` parameter, `height` sets the screenshot image height. Leave it unset to get full height.
69+
When `screenshot` is given for the `output` parameter, `height` sets the screenshot image height. Leave it unset to get full height. The default minimum height is `720` pixels.
7070

7171
###### Example
7272
```

‎web/include/class/browser/ScreenCapture.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function get( $sURL ) {
2929

3030
$request->setViewportSize(
3131
$_aRequestArguments[ 'width' ],
32-
1800 // any number will show full height
32+
720 // any number will show full height. This number serves as a minimum height.
3333
);
3434
if ( $_aRequestArguments[ 'height' ] ) {
3535
$request->setCaptureDimensions( $_aRequestArguments[ 'width' ], $_aRequestArguments[ 'height' ], 0, 0 );

‎web/include/class/scraper/Scraper_screenshot.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ protected function _construct() {
1616

1717
$this->_aRequestArguments[ 'width' ] = isset( $_REQUEST[ 'width' ] )
1818
? ( integer ) $_REQUEST[ 'width' ]
19-
: 1200;
19+
: 480;
2020
$this->_aRequestArguments[ 'height' ] = isset( $_REQUEST[ 'height' ] )
2121
? ( integer ) $_REQUEST[ 'height' ]
2222
: null; // to get all the height

‎web/include/template/form.php‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,10 @@
4040
</div>
4141
</section>
4242

43-
<div >
44-
<div class="column is-4 is-offset-one-third">
43+
<div class="level">
44+
<div style='width: 50%; margin-left: auto; margin-right: auto; text-align: center;'>
4545
<p>Type a URL and press <code class="is-small">Go</code>.</p>
46-
<p>Use the URL shown in the address bar.</p>
47-
<p>For more advanced usage, see <a href="<?php echo Registry::PROGRAM_URI;?>" target="_blank">here</a>.</p>
46+
<p>Use the URL shown in the address bar. For advanced usage, see <a href="<?php echo Registry::PROGRAM_URI;?>" target="_blank">here</a>.</p>
4847
</div>
4948
</div>
5049
<div class="columns" style="min-height: 420px;">

‎web/index.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class Registry {
1111
const SUBTITLE = 'Fetches even JavaScript generated contents.';
1212
const DESCRIPTION = 'A web page content proxy scraper, supporting JavaScript generated contents, a cross domain solution.';
1313
const PROGRAM_URI = 'https://github.com/michaeluno/php-simple-web-scraper';
14-
const VERSION = '1.3.1';
14+
const VERSION = '1.3.2';
1515
const AUTHOR = 'Michael Uno';
1616
const AUTHOR_URI = 'http://en.michaeluno.jp';
1717

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /