Commit 1b12ab4

committed

- Fixed a bug which caused a PHP notice, undefined index with accessing $_SERVER[ 'HTTP_USER_AGENT' ] when it is not set.

1 parent 98c6f34 commit 1b12ab4Copy full SHA for 1b12ab4

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`# Change Log`
`2`	`2`
	`3`	`+### 1.3.1`
	`4`	+- Fixed a bug which caused a PHP notice, undefined index with accessing `$_SERVER[ 'HTTP_USER_AGENT' ]` when it is not set.
	`5`	`+`
`3`	`6`	`### 1.3.0 - 2018年10月23日`
`4`	`7`	- Added the `width` and `height` parameters for the `screenshot` output type.
`5`	`8`	- Added the `cache-lifespan` parameter that determines the cache duration.

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,9 @@ private function ___getBaseArguments( array $aRequest ) {`
`98`	`98`	`}`
`99`	`99`	`private function ___getUserAgent( array $aRequest ) {`
`100`	`100`	`if ( ! isset( $aRequest[ 'user-agent' ] ) ) {`
`101`		`- return $_SERVER[ 'HTTP_USER_AGENT' ];`
	`101`	`+ return isset( $_SERVER[ 'HTTP_USER_AGENT' ] )`
	`102`	`+ ? $_SERVER[ 'HTTP_USER_AGENT' ]`
	`103`	`+ : '';`
`102`	`104`	`}`
`103`	`105`	`return 'random' === $aRequest[ 'user-agent' ]`
`104`	`106`	`? $this->getOneFromList( Registry::$sDirPath . '/include/user-agents.txt' )`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class Registry {`
`10`	`10`	`const SLUG = 'SimpleWebScraper';`
`11`	`11`	`const DESCRIPTION = 'PHP & PhantomJS driven web content scraper';`
`12`	`12`	`const PROGRAM_URI = 'https://github.com/michaeluno/php-simple-web-scraper';`
`13`		`- const VERSION = '1.3.0';`
	`13`	`+ const VERSION = '1.3.1';`
`14`	`14`	`const AUTHOR = 'Michael Uno';`
`15`	`15`	`const AUTHOR_URI = 'http://en.michaeluno.jp';`
`16`	`16`

Comments

(0)