Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bug Fixing #41

error-four-o-four started this conversation in General
Discussion options

Hey there,

Before that PR #31 the synth was connected directly to each effect with the property 'wet' set to 0. Because of that the Distortion Effect increased the volume of the synth initially without distorting it. So, to fix issue #39 one could create an extra Distortion Effect to prevent that change or drop of the volume, when the effect is turned on and off. I don't know if the gain of multiple distortion effects accumulate which could result in the same issue but I'll test it.
On the other hand it might be good to have an extra dial to control the value of the property 'wet' of each effect.

The error of Issue #35 occurred because the values of the options which are passed to the constructor of the Phaser effect were wrong. The value of the property octaves was 15. It seems like the Phaser has the most impact, when the octaves are between 0 and 10.

The reason the dials are not responding could also be because NexusUI doesn't dispatch a click event.
All the audio nodes are instantiated after the user made an input (e.g. click) to avoid all the warnings in the console and fulfil the autoplay policy. To fix this issue one could show the splash screen until the user has made an input. One could add a message like 'click or press any key to start' to the splash screen after all scripts are imported and loaded to make sure that all audio nodes are created and the dials are responsive before they're shown.

You must be logged in to vote

Replies: 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant

AltStyle によって変換されたページ (->オリジナル) /