Commit f4841ab

committed

Show error message when FormPanel is submitted blank.

1 parent b790e21 commit f4841abCopy full SHA for f4841ab

File tree

+18

-11

lines changed

+18

-11

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`from Component_py.stubs import require, console # __:skip`
`2`	`2`	`from actions.types import (`
`3`		`- FETCH_ALL_TODOS, COMPLETE_TODO, DELETE_TODO, ADD_NEW_TODO,`
	`3`	`+ FETCH_ALL_TODOS, COMPLETE_TODO, DELETE_TODO, ADD_NEW_TODO,ADD_NEW_TODO_REJECTED,`
`4`	`4`	`REGISTER_USER, REGISTER_USER_REJECTED, LOGIN_USER, LOGOUT_USER,`
`5`	`5`	`FORM_PANEL_UPDATE, LOGIN_FORM_UPDATE, CLEAR_LOGIN_FORM`
`6`	`6`	`)`
`@@ -39,6 +39,14 @@ def delete_todo(id_, token):`
`39`	`39`
`40`	`40`
`41`	`41`	`def add_new_todo(text, token):`
	`42`	`+ if not text:`
	`43`	`+ return {`
	`44`	`+ "type": ADD_NEW_TODO_REJECTED,`
	`45`	`+ "payload": {"response": {"data": {`
	`46`	`+ "message": "Please fill out the form."`
	`47`	`+ }}}`
	`48`	`+ }`
	`49`	`+`
`42`	`50`	`new_todo = {"text": text}`
`43`	`51`	`return {`
`44`	`52`	`"type": ADD_NEW_TODO,`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,8 @@ class ButtonPanel(Component):`
`18`	`18`	`def on_click_add(self):`
`19`	`19`	`text, token, form_panel_update, add_new_todo = destruct(`
`20`	`20`	`self.props, "text", "token", "form_panel_update", "add_new_todo")`
`21`		`- if text:`
`22`		`- add_new_todo(text, token)`
`23`		`- form_panel_update("")`
	`21`	`+ add_new_todo(text, token)`
	`22`	`+ form_panel_update("")`
`24`	`23`
`25`	`24`	`def on_click_clear(self):`
`26`	`25`	`text, form_panel_update = destruct(`

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,11 +22,9 @@ def render(self):`
`22`	`22`	`<FormGroup>`
`23`	`23`	`<Label for="text_input">Enter new todo text:</Label>`
`24`	`24`	`<Input`
`25`		`- className="no-shadow"`
`26`	`25`	`onChange={self.on_text_change}`
`27`	`26`	`value={self.props.text}`
`28`	`27`	`id="text_input"`
`29`		`- placeholder="What to do?"`
`30`		`- required={required} />`
	`28`	`+ placeholder="What to do?" />`
`31`	`29`	`</FormGroup>`
`32`	`30`	`); """)`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,19 +26,21 @@ def componentDidMount(self):`
`26`	`26`	`fetch_all_todos(token)`
`27`	`27`
`28`	`28`	`def on_click_complete(self, todo):`
	`29`	`+ complete, id_ = destruct(todo, "complete", "id")`
`29`	`30`	`token, complete_todo = destruct(self.props, "token", "complete_todo")`
`30`	`31`
`31`	`32`	`def closure():`
`32`		`- if not todo["complete"]:`
`33`		`- complete_todo(todo["id"], token)`
	`33`	`+ if not complete:`
	`34`	`+ complete_todo(id_, token)`
`34`	`35`	`return closure`
`35`	`36`
`36`	`37`	`def on_click_delete(self, todo):`
	`38`	`+ complete, id_ = destruct(todo, "complete", "id")`
`37`	`39`	`token, delete_todo = destruct(self.props, "token", "delete_todo")`
`38`	`40`
`39`	`41`	`def closure():`
`40`		`- if todo["complete"] or window.confirm('Delete incomplete Todo?'):`
`41`		`- delete_todo(todo["id"], token)`
	`42`	`+ if complete or window.confirm('Delete incomplete Todo?'):`
	`43`	`+ delete_todo(id_, token)`
`42`	`44`	`return closure`
`43`	`45`
`44`	`46`	`def render_checkmark(self, todo):`

Comments

(0)