Commit 9b82f3f

oschwaldclaude

and

committed

Replace legacy collections with modern alternatives

Replace Stack with ArrayDeque in Networks.java for better performance by removing unnecessary synchronization overhead. Replace Vector with ArrayList in test code for consistency with modern Java practices. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

1 parent 2654c85 commit 9b82f3fCopy full SHA for 9b82f3f

File tree

2 files changed

-6

lines changed

src
- main/java/com/maxmind/db
  - Networks.java
- test/java/com/maxmind/db
  - ReaderTest.java

2 files changed

-6

lines changed

`‎src/main/java/com/maxmind/db/Networks.java‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,9 +3,10 @@`
`3`	`3`	`import java.io.IOException;`
`4`	`4`	`import java.net.Inet4Address;`
`5`	`5`	`import java.net.InetAddress;`
	`6`	`+import java.util.ArrayDeque;`
`6`	`7`	`import java.util.Arrays;`
	`8`	`+import java.util.Deque;`
`7`	`9`	`import java.util.Iterator;`
`8`		`-import java.util.Stack;`
`9`	`10`
`10`	`11`	`/**`
`11`	`12`	`* Instances of this class provide an iterator over the networks in a database.`
`@@ -15,7 +16,7 @@`
`15`	`16`	`*/`
`16`	`17`	`public final class Networks<T> implements Iterator<DatabaseRecord<T>> {`
`17`	`18`	`private final Reader reader;`
`18`		`- private final Stack<NetworkNode> nodes;`
	`19`	`+ private final Deque<NetworkNode> nodes;`
`19`	`20`	`private NetworkNode lastNode;`
`20`	`21`	`private final boolean includeAliasedNetworks;`
`21`	`22`	`private final Buffer buffer; /* Stores the buffer for Next() calls */`
`@@ -39,7 +40,7 @@ public final class Networks<T> implements Iterator<DatabaseRecord<T>> {`
`39`	`40`	`this.reader = reader;`
`40`	`41`	`this.includeAliasedNetworks = includeAliasedNetworks;`
`41`	`42`	`this.buffer = reader.getBufferHolder().get();`
`42`		`- this.nodes = new Stack<>();`
	`43`	`+ this.nodes = new ArrayDeque<>();`
`43`	`44`	`this.typeParameterClass = typeParameterClass;`
`44`	`45`	`for (NetworkNode node : nodes) {`
`45`	`46`	`this.nodes.push(node);`

`‎src/test/java/com/maxmind/db/ReaderTest.java‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@`
`27`	`27`	`import java.util.HashMap;`
`28`	`28`	`import java.util.List;`
`29`	`29`	`import java.util.Map;`
`30`		`-import java.util.Vector;`
`31`	`30`	`import java.util.concurrent.ConcurrentHashMap;`
`32`	`31`	`import java.util.stream.IntStream;`
`33`	`32`
`@@ -1397,12 +1396,12 @@ public void testDecodeVector(int chunkSize) throws IOException {`
`1397`	`1396`	`}`
`1398`	`1397`
`1399`	`1398`	`static class TestModelVector {`
`1400`		`- Vector<Long> arrayField;`
	`1399`	`+ ArrayList<Long> arrayField;`
`1401`	`1400`
`1402`	`1401`	`@MaxMindDbConstructor`
`1403`	`1402`	`public TestModelVector(`
`1404`	`1403`	`@MaxMindDbParameter(name = "array")`
`1405`		`- Vector<Long> arrayField`
	`1404`	`+ ArrayList<Long> arrayField`
`1406`	`1405`	`) {`
`1407`	`1406`	`this.arrayField = arrayField;`
`1408`	`1407`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 9b82f3f

File tree

2 files changed

2 files changed

`‎src/main/java/com/maxmind/db/Networks.java‎`

`‎src/test/java/com/maxmind/db/ReaderTest.java‎`

0 commit comments